Skip to content

Conversation

@wangzelin007
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings May 22, 2025 05:47
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented May 22, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @wangzelin007,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented May 22, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the download URLs for the ml extension in src/index.json to point at the new production blob endpoint (azcliprod), and updates GitHub automation policies and CODEOWNERS to include wangzelin007.

  • Bulk replace of downloadUrl values in src/index.json to use https://azcliprod.blob.core.windows.net/...
  • Added wangzelin007 as reviewer/assignee in .github/policies/resourceManagement.yml
  • Added wangzelin007 to CODEOWNERS and adjusted listing in .github/CODEOWNERS

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/index.json Updated downloadUrl entries to new endpoint
.github/policies/resourceManagement.yml Added new reviewer/assignee and adjusted YAML
.github/CODEOWNERS Included wangzelin007 in CODEOWNERS
Comments suppressed due to low confidence (2)

.github/policies/resourceManagement.yml:3338

  • [nitpick] Indentation for this reviewer: entry is deeper than the previous - requestReview: list marker. Align the dash and nested keys consistently for readability.
          reviewer: wangzelin007

.github/policies/resourceManagement.yml:3343

  • [nitpick] The list under assignTo: mixes indentation styles. Make sure all list items use the same indent level to prevent YAML parsing issues.
          - wangzelin007

@github-actions
Copy link

@wangzelin007 wangzelin007 merged commit 9a05db7 into Azure:main May 22, 2025
26 checks passed
bavneetsingh16 pushed a commit to AzureArcForKubernetes/k8s-extension that referenced this pull request May 23, 2025
…liprod (Azure#8780)

* Migrate ml extensions downloadUrl from azuremlsdktestpypi to azcliprod

* minor fix

* minor fix

* minor fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants