Skip to content

Conversation

@AntonioND
Copy link
Member

@AntonioND AntonioND commented May 22, 2025

This code is no longer required. Its original purpose was to generate a join token without user input to simplify the setup of the extension.

This PR is the same as AzureArcForKubernetes#287 but applied to this repository.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az k8s-extension create

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings May 22, 2025 10:06
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented May 22, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @AntonioND,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented May 22, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the now-unneeded EntraWorkloadIAM extension and its associated tests and registration.

  • Deleted all tests for the EntraWorkloadIAM partner extension.
  • Removed the EntraWorkloadIAM implementation module.
  • Cleared the EntraWorkloadIAM import and factory mapping in custom.py.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/k8s-extension/azext_k8s_extension/tests/latest/test_entra_workload_iam.py Removed tests for EntraWorkloadIAM
src/k8s-extension/azext_k8s_extension/partner_extensions/EntraWorkloadIAM.py Deleted EntraWorkloadIAM extension implementation
src/k8s-extension/azext_k8s_extension/custom.py Removed import and factory entry for EntraWorkloadIAM

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented May 22, 2025

Copy link

@dafang982 dafang982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonzhan yonzhan requested a review from yanzhudd July 28, 2025 09:49
@AntonioND
Copy link
Member Author

AntonioND commented Jul 28, 2025

Hi! Can I get a review here? The Arc extension that required this code was cancelled months ago. This is dead code and it should be removed.

@zhoxing-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@AntonioND
Copy link
Member Author

It looks like all the style issues in the pipelines are in code that hasn't been touched by this PR.

@zhoxing-ms zhoxing-ms merged commit aaf5aa6 into Azure:main Jul 29, 2025
22 of 24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ k8s-extension-1.6.6 ] : https://dev.azure.com/msazure/One/_build/results?buildId=131982681&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants