Skip to content

Comments

[Containerapp] Update api-version to 2025-02-02-preview#8791

Merged
zhoxing-ms merged 10 commits intoAzure:mainfrom
Greedygre:xinyu/20250525_update_2025_0202_preview_version
May 28, 2025
Merged

[Containerapp] Update api-version to 2025-02-02-preview#8791
zhoxing-ms merged 10 commits intoAzure:mainfrom
Greedygre:xinyu/20250525_update_2025_0202_preview_version

Conversation

@Greedygre
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings May 26, 2025 13:31
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented May 26, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @Greedygre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented May 26, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Contributor

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Containerapp extension to use the new preview API version and adjusts test scenarios to inject virtual network subnet parameters.

  • Bumps the default preview API version to 2025-02-02-preview
  • Modifies tests to disable random_config_dir and consistently pass subnet IDs via a new SubnetPreparer or utility function
  • Extends enum definitions and adjusts identity setup guard in session-pool decorator

Reviewed Changes

Copilot reviewed 174 out of 174 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/containerapp/azext_containerapp/_clients.py Updated PREVIEW_API_VERSION constant to 2025-02-02-preview
src/containerapp/azext_containerapp/tests/latest/… Dozens of test files: set random_config_dir=False, import/use create_vent_subnet or SubnetPreparer, and add -s {subnet_id} flags
src/containerapp/azext_containerapp/tests/latest/custom_preparers.py Changed default SubnetPreparer location to "centralus"
src/containerapp/azext_containerapp/_sdk_enums.py Added several new enum values (e.g., DELETING, LifecycleType, patching enums) and removed ExecutionType
src/containerapp/azext_containerapp/containerapp_sessionpool_decorator.py Wrapped identity initialization in a conditional guard
src/containerapp/azext_containerapp/_decorator_utils.py Added "runningState" to processed nested YAML properties
Comments suppressed due to low confidence (3)

src/containerapp/azext_containerapp/tests/latest/test_containerapp_mount_secret_volume.py:13

  • [nitpick] The helper function name 'create_vent_subnet' appears to have a typo; consider renaming it to 'create_vnet_subnet' for clarity and consistency.
from .utils import create_containerapp_env, create_vent_subnet

src/containerapp/azext_containerapp/_sdk_enums.py:279

  • Removing the ExecutionType enum may introduce a breaking change for consumers relying on it; consider deprecating or aliasing it before full removal.
class ExecutionType(str, Enum, metaclass=CaseInsensitiveEnumMeta):

src/containerapp/azext_containerapp/containerapp_sessionpool_decorator.py:222

  • Introducing this guard changes the default behavior of set_up_managed_identity by skipping identity initialization when no identity flags are provided. Verify this change is intentional and does not break existing workflows.
if self.get_argument_user_assigned() or self.get_argument_system_assigned() or self.get_argument_registry_identity():

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2025

Hi @Greedygre

Release Suggestions

Module: containerapp

  • Update VERSION to 1.1.0b6 in src/containerapp/setup.py

Notes

@zhoxing-ms zhoxing-ms merged commit 1734250 into Azure:main May 28, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants