[DataFactory] Support Oracle V2 app model#8792
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @Jingshu918, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for new features in ADF 1.0.4 by introducing additional enums and updating version information.
- Introduces new enums (e.g. AzurePostgreSqlWriteMethodEnum, GreenplumAuthenticationType, OracleAuthenticationType, ValueType) in the management client models.
- Updates the init.py file to export the newly added enum classes.
- Increments version numbers in both vendored SDK and manual version files and updates HISTORY.rst.
- Removes explicit inheritance from object in serializer/deserializer classes within _serialization.py for a more modern Python style.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/datafactory/azext_datafactory/vendored_sdks/datafactory/models/_data_factory_management_client_enums.py | Adds new enum classes for supporting new features. |
| src/datafactory/azext_datafactory/vendored_sdks/datafactory/models/init.py | Updates the exports to include new enum classes. |
| src/datafactory/azext_datafactory/vendored_sdks/datafactory/_version.py | Updates version number from 9.1.0 to 9.2.0. |
| src/datafactory/azext_datafactory/vendored_sdks/datafactory/_serialization.py | Removes explicit “object” inheritance in class definitions. |
| src/datafactory/azext_datafactory/manual/version.py | Updates manual version from 1.0.3 to 1.0.4. |
| src/datafactory/HISTORY.rst | Updates history to reflect the new changes in 1.0.4. |
|
|
Hi, can you add tests for these new features? |
|
@calvinhzy Is it necessary we add tests? |
|
[Release] Update index.json for extension [ datafactory-1.0.4 ] : https://dev.azure.com/msazure/One/_build/results?buildId=125668068&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
We only update the python sdk used by CLI. The new feature is app model changes.
https://learn.microsoft.com/en-us/azure/data-factory/connector-overview
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.