Skip to content

Comments

Support SessionPool for API version 202502-02-preview#8793

Closed
yitaopan wants to merge 2 commits intoAzure:mainfrom
yitaopan:yitaopan/support-sessions-api-version-20250202p
Closed

Support SessionPool for API version 202502-02-preview#8793
yitaopan wants to merge 2 commits intoAzure:mainfrom
yitaopan:yitaopan/support-sessions-api-version-20250202p

Conversation

@yitaopan
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings May 27, 2025 09:40
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @yitaopan,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented May 27, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Contributor

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the new session pool lifecycleConfiguration schema under API version 2025-02-02-preview, updates test validations accordingly, and wires up the new API version in the SDK client.

  • Refactored dynamicPoolConfiguration to nest executionType and cooldown under lifecycleConfiguration
  • Enhanced tests to assert lifecycleConfiguration fields and added SubnetPreparer decorators
  • Updated SessionPoolPreviewClient to use the literal "2025-02-02-preview" version

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

File Description
src/containerapp/azext_containerapp/tests/latest/test_containerapp_sessionpool.py Added lifecycleConfiguration JMESPath checks and SubnetPreparer; updated test signatures
src/containerapp/azext_containerapp/containerapp_sessionpool_decorator.py Refactored set_up_dynamic_configuration to build a lifecycleConfiguration object
src/containerapp/azext_containerapp/_clients.py Switched SessionPoolPreviewClient.api_version to "2025-02-02-preview"
Comments suppressed due to low confidence (2)

src/containerapp/azext_containerapp/containerapp_sessionpool_decorator.py:484

  • There are two methods named set_up_dynamic_configuration in this class; the second definition overrides the first, likely dropping needed config. Rename or consolidate them to preserve both behaviors.
def set_up_dynamic_configuration(self):

src/containerapp/azext_containerapp/tests/latest/test_containerapp_sessionpool.py:142

  • Duplicate @ResourceGroupPreparer decorator on test_containerapp_sessionpool_registry_update will cause the test signature to receive resource_group twice and break. Remove the redundant decorator.
@ResourceGroupPreparer()

@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2025

Hi @yitaopan

⚠️ Release Requirements

Module: acrcssc

  • ⚠️ Please update VERSION to be 1.0.0b3 in src/acrcssc/setup.py

Module: aks-preview

  • ⚠️ Please update VERSION to be 18.0.0b5 in src/aks-preview/setup.py

Module: containerapp

  • Update VERSION to 1.1.0b6 in src/containerapp/setup.py

Notes

@yonzhan yonzhan requested a review from zhoxing-ms May 27, 2025 10:10
@yonzhan yonzhan requested a review from yanzhudd May 27, 2025 10:12
@yitaopan yitaopan marked this pull request as draft May 27, 2025 11:09
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 28, 2025
@yitaopan yitaopan closed this May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants