[AKS] Add option Ubuntu2204 and Ubuntu2404 to --os-sku for az aks nodepool add and az aks nodepool update#8795
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @anujmaheshwari1, |
There was a problem hiding this comment.
Pull Request Overview
This PR expands the available OS SKU options for AKS nodepools by adding support for Ubuntu-based images.
- Adds constants and updates parameter lists for Ubuntu2204 and Ubuntu2404.
- Updates help documentation and HISTORY to reflect the new options.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py | Added a test for Ubuntu2204 using the new --os-sku option. |
| src/aks-preview/azext_aks_preview/_params.py | Updated parameter lists to include Ubuntu2204 and Ubuntu2404. |
| src/aks-preview/azext_aks_preview/_help.py | Revised help text to list Ubuntu2204 and Ubuntu2404. |
| src/aks-preview/azext_aks_preview/_consts.py | Defined new constants for Ubuntu2204 and Ubuntu2404. |
| src/aks-preview/HISTORY.rst | Updated history with the new OS SKU option. |
Comments suppressed due to low confidence (1)
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py:2716
- Consider adding tests for Ubuntu2404 to ensure both new OS SKU options are adequately covered.
@AllowLargeResponse()
src/aks-preview/HISTORY.rst
Outdated
| * [BREAKING CHANGE] Rename `--enable-addon-autoscaling` to `--enable-optimized-addon-scaling` to `az aks create` commands. | ||
| * [BREAKING CHANGE] Rename `--enable-addon-autoscaling` to `--enable-optimized-addon-scaling` and `--disable-addon-autoscaling` to `--disable-optimized-addon-scaling` to `az aks update` commands. | ||
|
|
||
| * Add option `Ubuntu2204` to `--os-sku` for `az aks nodepool add` and `az aks nodepool update`. |
There was a problem hiding this comment.
The HISTORY entry mentions only Ubuntu2204; please update it to include Ubuntu2404 as well, in line with the changes made in the parameters and help documentation.
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
applied fix for failed test cases in PR #8798 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Please update recording file |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
...w/azext_aks_preview/tests/latest/recordings/test_aks_nodepool_add_with_ossku_ubuntu2204.yaml
Outdated
Show resolved
Hide resolved
…_aks_nodepool_add_with_ossku_ubuntu2204.yaml Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ aks-preview-18.0.0b5 ] : https://dev.azure.com/msazure/One/_build/results?buildId=125651844&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks nodepool add
az aks nodepool update
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.