Skip to content

Fixes device run-ro command failure when response is missing some fields, and updates tests #8813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kairu-ms merged 2 commits into from
Jun 4, 2025
Merged

Fixes device run-ro command failure when response is missing some fields, and updates tests #8813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56e9686
Adds check and tests for empty fields
ejiadedeji May 29, 2025
406c6e3
Updates link
ejiadedeji May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/managednetworkfabric/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
Release History
===============

8.0.0b4
++++++
* Fixes 'device run-ro' command for missing fields in the response.

8.0.0b3
++++++
* Adding custom output formatting for 'device' run-ro command
Expand Down
10 changes: 7 additions & 3 deletions src/managednetworkfabric/azext_managednetworkfabric/operations/custom_properties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,12 @@ def _output(parent_cmd, *args, **kwargs): # pylint: disable=unused-argument
op_response = parent_cmd.ctx.vars.instance.properties.to_serialized_data()

new_properties = {}
new_properties["configurationState"] = op_response["configurationState"]
new_properties["outputUrl"] = op_response["outputUrl"]

if has_value(parent_cmd.ctx.vars.instance.properties.configuration_state):
new_properties["configurationState"] = op_response["configurationState"]

if has_value(parent_cmd.ctx.vars.instance.properties.output_url):
new_properties["outputUrl"] = op_response["outputUrl"]

if has_value(
parent_cmd.ctx.vars.instance.properties.device_configuration_preview
Expand All @@ -50,6 +54,6 @@ def _output(parent_cmd, *args, **kwargs): # pylint: disable=unused-argument
logger.warning(json_string)
new_properties["deviceConfigurationPreview"] = json_string
else:
new_properties["deviceConfigurationPreview"] = "{}"
new_properties["deviceConfigurationPreview"] = {}

return new_properties
Loading
Loading