Skip to content

Conversation

@nielsams
Copy link
Member

@nielsams nielsams commented Jun 2, 2025

1.0.0b4
++++++

  • Force resource group input to lowercase for comparison with ARG results
  • Added support for the following resource types:
    • NAT Gateways
    • Public IP Prefixes
    • Container Apps Jobs

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az zones validate

General Guidelines

  • [ X ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [ X ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [ X ] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 2, 2025 08:45
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 2, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 2, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jun 2, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the 1.0.0b4 release by normalizing resource group input, adding zone-validation for new resource types, bumping the extension version, and updating docs/history.

  • Force resource group names to lowercase for ARG comparisons
  • Add zone-redundancy checks for NAT Gateways, Public IP Prefixes, and Container App Jobs
  • Bump version to 1.0.0b4; update README and release history

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/zones/setup.py Bump extension version to 1.0.0b4
src/zones/azext_zones/resource_type_validators/microsoft_network.py Add validators for NAT Gateways and Public IP Prefixes
src/zones/azext_zones/resource_type_validators/microsoft_app.py Add validator for Container App Jobs
src/zones/azext_zones/_argHelper.py Lowercase resource group input for ARG query
src/zones/README.md Note that tags are case-sensitive
src/zones/HISTORY.rst Document new 1.0.0b4 release items
Comments suppressed due to low confidence (3)

src/zones/azext_zones/resource_type_validators/microsoft_network.py:71

  • No unit tests cover the new natgateways validation path. Add tests for cases where resource.get('zones') returns 0, 1, and multiple entries to ensure correct Yes/No behavior.
if resourceSubType == "natgateways":

src/zones/azext_zones/resource_type_validators/microsoft_network.py:118

  • The publicipprefixes validator block is untested. Consider adding unit tests for scenarios with zero, one, and multiple zones.
if resourceSubType == "publicipprefixes":

src/zones/azext_zones/resource_type_validators/microsoft_app.py:31

  • The new jobs validation path lacks coverage. Add tests to verify that Container App Jobs return Dependent as expected.
if resourceSubType == "jobs":

@github-actions
Copy link

github-actions bot commented Jun 2, 2025

@AllyW
Copy link
Contributor

AllyW commented Jun 4, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@zhoxing-ms zhoxing-ms merged commit 4debd03 into Azure:main Jun 5, 2025
38 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Jun 5, 2025

[Release] Update index.json for extension [ zones-1.0.0b4 ] : https://dev.azure.com/msazure/One/_build/results?buildId=126348429&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants