-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[azure-firewall] Add command examples #8824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @cxznmhdcxz, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds command examples for various Azure Firewall commands across both the CLI and AAZ interfaces.
- Adds new CLI commands for intrusion detection (both policy and draft) with example usage.
- Updates AAZ command examples for creating firewall policy rule collection groups and policies.
- Updates help documentation with new examples for network rule and NAT rule commands.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/azure-firewall/azext_firewall/custom.py | Introduces new intrusion-detection add commands with example usage. |
| src/azure-firewall/azext_firewall/aaz/latest/network/firewall/policy/rule_collection_group/draft/_create.py | Adds an example for creating a draft rule collection group. |
| src/azure-firewall/azext_firewall/aaz/latest/network/firewall/policy/rule_collection_group/_create.py | Adds an example for creating a rule collection group. |
| src/azure-firewall/azext_firewall/aaz/latest/network/firewall/policy/draft/_create.py | Adds an example for creating a draft firewall policy. |
| src/azure-firewall/azext_firewall/aaz/latest/network/firewall/policy/_create.py | Adds an example for creating a firewall policy. |
| src/azure-firewall/azext_firewall/_help.py | Updates help examples for network and NAT rules. |
Comments suppressed due to low confidence (1)
src/azure-firewall/azext_firewall/custom.py:1146
- Consider correcting 'overrided' to 'override' for clarity in the command description.
Add overrided intrusion signature or a bypass rule or private ranges list for intrusion detection
| examples: | ||
| - name: Create a network rule | ||
| text: | | ||
| az network firewall network-rule create -g myrg -n network-rule -c collection --priority --action Allow -f af1 \ |
Copilot
AI
Jun 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example usage for '--priority' is missing a sample value; consider adding a numeric value (e.g. '--priority 100') to improve clarity in the documentation.
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @cxznmhdcxz Release SuggestionsModule: azure-firewall
Notes
|
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.