Skip to content

Conversation

@cxznmhdcxz
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 3, 2025 03:56
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 3, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@cxznmhdcxz cxznmhdcxz requested a review from jsntcy as a code owner June 3, 2025 03:56
@azure-client-tools-bot-prd
Copy link

Hi @cxznmhdcxz,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 3, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds command examples for various Azure Firewall commands across both the CLI and AAZ interfaces.

  • Adds new CLI commands for intrusion detection (both policy and draft) with example usage.
  • Updates AAZ command examples for creating firewall policy rule collection groups and policies.
  • Updates help documentation with new examples for network rule and NAT rule commands.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/azure-firewall/azext_firewall/custom.py Introduces new intrusion-detection add commands with example usage.
src/azure-firewall/azext_firewall/aaz/latest/network/firewall/policy/rule_collection_group/draft/_create.py Adds an example for creating a draft rule collection group.
src/azure-firewall/azext_firewall/aaz/latest/network/firewall/policy/rule_collection_group/_create.py Adds an example for creating a rule collection group.
src/azure-firewall/azext_firewall/aaz/latest/network/firewall/policy/draft/_create.py Adds an example for creating a draft firewall policy.
src/azure-firewall/azext_firewall/aaz/latest/network/firewall/policy/_create.py Adds an example for creating a firewall policy.
src/azure-firewall/azext_firewall/_help.py Updates help examples for network and NAT rules.
Comments suppressed due to low confidence (1)

src/azure-firewall/azext_firewall/custom.py:1146

  • Consider correcting 'overrided' to 'override' for clarity in the command description.
Add overrided intrusion signature or a bypass rule or private ranges list for intrusion detection

examples:
- name: Create a network rule
text: |
az network firewall network-rule create -g myrg -n network-rule -c collection --priority --action Allow -f af1 \
Copy link

Copilot AI Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example usage for '--priority' is missing a sample value; consider adding a numeric value (e.g. '--priority 100') to improve clarity in the documentation.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Jun 3, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

Hi @cxznmhdcxz

Release Suggestions

Module: azure-firewall

  • Please log updates into to src/azure-firewall/HISTORY.rst
  • Update VERSION to 1.2.4 in src/azure-firewall/setup.py

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants