Skip to content

Conversation

@xmzhao0822
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks namespace list
az aks namespace list --resource-group
az aks namespace list --resource-group --cluster-name

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 3, 2025 21:19
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 3, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1009 - ParaPropRemove aks namespace list cmd aks namespace list update parameter cluster_name: removed property required=True
⚠️ 1009 - ParaPropRemove aks namespace list cmd aks namespace list update parameter resource_group_name: removed property required=True

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 3, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for listing managed namespaces across subscription and resource group scopes, updates related tests and formatting, and bumps extension version.

  • Bumps extension version to 18.0.0b9
  • Extends aks namespace list to handle resource group– and subscription-level listings, with new tests
  • Updates table formatter to handle resources without properties and records change in HISTORY.rst

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/aks-preview/setup.py Version updated to 18.0.0b9
src/aks-preview/azext_aks_preview/custom.py Wrapped list logic for RG/cluster vs. subscription scopes
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Added tests for RG-only and subscription-level namespace listing
src/aks-preview/azext_aks_preview/_format.py Added branch to format resources lacking properties
src/aks-preview/HISTORY.rst Recorded 18.0.0b9 release entry
Comments suppressed due to low confidence (2)

src/aks-preview/HISTORY.rst:17

  • [nitpick] The history entry uses the term “ARG”, which may be a typo or unclear abbreviation. Consider clarifying whether this refers to ARM or Azure Resource Graph.
* Wrap the ARG call in the managed namespace list command

src/aks-preview/azext_aks_preview/_format.py:96

  • The table formatter shows resourceGroup and location only for resources without properties, but omits them for the default branch. You may want to include consistent columns (e.g. resourceGroup, location) in both cases for a uniform output.
    if not result.get("properties"):

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Queued live test to validate the change, test passed!

  • test_aks_managed_namespace

FumingZhang
FumingZhang previously approved these changes Jun 4, 2025
@yanzhudd
Copy link
Contributor

yanzhudd commented Jun 4, 2025

please resolve the code conflict.

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 4, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 4, 2025
@yanzhudd yanzhudd merged commit 389ebe7 into Azure:main Jun 4, 2025
24 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Jun 4, 2025

[Release] Update index.json for extension [ aks-preview-18.0.0b10 ] : https://dev.azure.com/msazure/One/_build/results?buildId=126204525&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants