-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[AKS] az aks update: Add --enable-http-proxy option
#8826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks update | cmd aks update added parameter enable_http_proxy |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for a new parameter (--enable-http-proxy) in the AKS commands to explicitly enable HTTP proxy configuration for managed clusters.
- Bump the extension version in setup.py from 18.0.0b8 to 18.0.0b9.
- Add new parameter definitions and help entries for enable_http_proxy in _params.py and _help.py.
- Update the decorator logic in managed_cluster_decorator.py and add tests in the test suites to cover the new functionality.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/setup.py | Bumped the version to reflect the new change. |
| src/aks-preview/linter_exclusions.yml | Added linter exclusion for the new enable_http_proxy option. |
| src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py | Added tests for enabling HTTP proxy configuration. |
| src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py | Added a test case to verify the --enable-http-proxy CLI command behavior. |
| src/aks-preview/azext_aks_preview/managed_cluster_decorator.py | Implemented getter and update methods for enable_http_proxy handling. |
| src/aks-preview/azext_aks_preview/custom.py | Updated function signature to include enable_http_proxy. |
| src/aks-preview/azext_aks_preview/_params.py | Added the CLI argument for enable_http_proxy. |
| src/aks-preview/azext_aks_preview/_help.py | Updated the help documentation to include the new option. |
| src/aks-preview/HISTORY.rst | Documented the change in the extension history. |
Comments suppressed due to low confidence (1)
src/aks-preview/azext_aks_preview/managed_cluster_decorator.py:5359
- Both --disable-http-proxy and --enable-http-proxy flags are checked separately, meaning that if both are set, the enable flag will override the disable flag without notification. Consider adding a mutual exclusion check or clarifying the precedence in documentation to avoid confusion for users.
if self.context.get_enable_http_proxy():
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
|
Please resolve merge conflict |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
The github actions somehow got stuck, could you push an empty commit to trigger the CI again? |
az aks update: Add --enable-http-proxy option
|
please resolve the code conflict. |
|
[Release] Update index.json for extension [ aks-preview-18.0.0b13 ] : https://dev.azure.com/msazure/One/_build/results?buildId=127357055&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks update --enable-http-proxy
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.