Skip to content

Conversation

@lilypan26
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks update --enable-http-proxy

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 4, 2025 01:42
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 4, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter enable_http_proxy

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 4, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a new parameter (--enable-http-proxy) in the AKS commands to explicitly enable HTTP proxy configuration for managed clusters.

  • Bump the extension version in setup.py from 18.0.0b8 to 18.0.0b9.
  • Add new parameter definitions and help entries for enable_http_proxy in _params.py and _help.py.
  • Update the decorator logic in managed_cluster_decorator.py and add tests in the test suites to cover the new functionality.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/aks-preview/setup.py Bumped the version to reflect the new change.
src/aks-preview/linter_exclusions.yml Added linter exclusion for the new enable_http_proxy option.
src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py Added tests for enabling HTTP proxy configuration.
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Added a test case to verify the --enable-http-proxy CLI command behavior.
src/aks-preview/azext_aks_preview/managed_cluster_decorator.py Implemented getter and update methods for enable_http_proxy handling.
src/aks-preview/azext_aks_preview/custom.py Updated function signature to include enable_http_proxy.
src/aks-preview/azext_aks_preview/_params.py Added the CLI argument for enable_http_proxy.
src/aks-preview/azext_aks_preview/_help.py Updated the help documentation to include the new option.
src/aks-preview/HISTORY.rst Documented the change in the extension history.
Comments suppressed due to low confidence (1)

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py:5359

  • Both --disable-http-proxy and --enable-http-proxy flags are checked separately, meaning that if both are set, the enable flag will override the disable flag without notification. Consider adding a mutual exclusion check or clarifying the precedence in documentation to avoid confusion for users.
if self.context.get_enable_http_proxy():

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 4, 2025
@FumingZhang
Copy link
Member

Please resolve merge conflict

@lilypan26
Copy link
Contributor Author

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd
Copy link
Contributor

yanzhudd commented Jun 6, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd yanzhudd closed this Jun 6, 2025
@yanzhudd yanzhudd reopened this Jun 6, 2025
@FumingZhang
Copy link
Member

The github actions somehow got stuck, could you push an empty commit to trigger the CI again? git commit --allow-empty -m "trigger CI" @lilypan26

@yanzhudd yanzhudd changed the title [AKS] Add --enable-http-proxy option [AKS] az aks update: Add --enable-http-proxy option Jun 6, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 10, 2025
@yanzhudd
Copy link
Contributor

please resolve the code conflict.

@yanzhudd yanzhudd merged commit a47d1ab into Azure:main Jun 15, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview-18.0.0b13 ] : https://dev.azure.com/msazure/One/_build/results?buildId=127357055&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants