Skip to content

Conversation

@caoyihua
Copy link
Contributor

@caoyihua caoyihua commented Jun 4, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az vme list

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 4, 2025 08:08
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 4, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️vme
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd vme list cmd vme list added

@azure-client-tools-bot-prd
Copy link

Hi @caoyihua,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 4, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new "vme list" command along with necessary utilities, command registration, parameters, help information, and formatting support. Key changes include:

  • Version bump in setup.py.
  • Addition of a spinner animation in utils.py to provide visual feedback during long-running subprocess calls.
  • Introduction of a new "list_vme" implementation and corresponding command and parameter definitions.
  • Refinement of extension name constants in consts.py and usage adjustments in custom.py.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/vme/setup.py Version bump update
src/vme/azext_vme/utils.py Added a spinner animation for subprocess calls
src/vme/azext_vme/custom.py Updated extension name references and added state check logic
src/vme/azext_vme/consts.py Renamed constants for clarity
src/vme/azext_vme/commands.py Registered new "list" command with table formatting
src/vme/azext_vme/_params.py Added new arguments for "vme list" command
src/vme/azext_vme/_help.py Provided help text for the new command
src/vme/azext_vme/_format.py Added table formatter for "vme list" output
Comments suppressed due to low confidence (2)

src/vme/azext_vme/custom.py:48

  • It would be helpful to add a comment explaining why a 'Failed' provisioning state is treated the same as a missing resource to aid future maintainers.
if ext.properties['provisioningState'] == 'Failed':

src/vme/azext_vme/consts.py:37

  • The similar naming of 'BundleExtensionTypeNames' and 'BundleExtensionNames' can be confusing; consider renaming one of them for improved clarity.
BundleExtensionTypeNames = {

src/vme/setup.py Outdated

# HISTORY.rst entry.
VERSION = '1.0.0b1'
VERSION = '1.0.1b1'
Copy link

Copilot AI Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the version bump from '1.0.0b1' to '1.0.1b1' aligns with semver and the intended release changes.

Suggested change
VERSION = '1.0.1b1'
VERSION = '1.1.0b1'

Copilot uses AI. Check for mistakes.

if logstatus:
animation = PollingAnimation()
spinner_thread = threading.Thread(target=animation.tick)
Copy link

Copilot AI Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider marking the spinner_thread as a daemon (using daemon=True) to ensure that it does not block process exit unexpectedly.

Suggested change
spinner_thread = threading.Thread(target=animation.tick)
spinner_thread = threading.Thread(target=animation.tick, daemon=True)

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Jun 4, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 4, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 4, 2025
@yonzhan yonzhan requested a review from kairu-ms June 4, 2025 08:58
@yonzhan yonzhan requested a review from jsntcy June 4, 2025 08:58
@kairu-ms kairu-ms merged commit 930a73d into Azure:main Jun 5, 2025
24 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Jun 5, 2025

[Release] Update index.json for extension [ vme-1.0.0b2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=126332493&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants