-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[vme] Add new vme command #8827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| vme list | cmd vme list added |
|
Hi @caoyihua, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new "vme list" command along with necessary utilities, command registration, parameters, help information, and formatting support. Key changes include:
- Version bump in setup.py.
- Addition of a spinner animation in utils.py to provide visual feedback during long-running subprocess calls.
- Introduction of a new "list_vme" implementation and corresponding command and parameter definitions.
- Refinement of extension name constants in consts.py and usage adjustments in custom.py.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vme/setup.py | Version bump update |
| src/vme/azext_vme/utils.py | Added a spinner animation for subprocess calls |
| src/vme/azext_vme/custom.py | Updated extension name references and added state check logic |
| src/vme/azext_vme/consts.py | Renamed constants for clarity |
| src/vme/azext_vme/commands.py | Registered new "list" command with table formatting |
| src/vme/azext_vme/_params.py | Added new arguments for "vme list" command |
| src/vme/azext_vme/_help.py | Provided help text for the new command |
| src/vme/azext_vme/_format.py | Added table formatter for "vme list" output |
Comments suppressed due to low confidence (2)
src/vme/azext_vme/custom.py:48
- It would be helpful to add a comment explaining why a 'Failed' provisioning state is treated the same as a missing resource to aid future maintainers.
if ext.properties['provisioningState'] == 'Failed':
src/vme/azext_vme/consts.py:37
- The similar naming of 'BundleExtensionTypeNames' and 'BundleExtensionNames' can be confusing; consider renaming one of them for improved clarity.
BundleExtensionTypeNames = {
src/vme/setup.py
Outdated
|
|
||
| # HISTORY.rst entry. | ||
| VERSION = '1.0.0b1' | ||
| VERSION = '1.0.1b1' |
Copilot
AI
Jun 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the version bump from '1.0.0b1' to '1.0.1b1' aligns with semver and the intended release changes.
| VERSION = '1.0.1b1' | |
| VERSION = '1.1.0b1' |
|
|
||
| if logstatus: | ||
| animation = PollingAnimation() | ||
| spinner_thread = threading.Thread(target=animation.tick) |
Copilot
AI
Jun 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider marking the spinner_thread as a daemon (using daemon=True) to ensure that it does not block process exit unexpectedly.
| spinner_thread = threading.Thread(target=animation.tick) | |
| spinner_thread = threading.Thread(target=animation.tick, daemon=True) |
|
|
[Release] Update index.json for extension [ vme-1.0.0b2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=126332493&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az vme list
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.