Skip to content

Conversation

@andborja
Copy link
Contributor

@andborja andborja commented Jun 4, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Bavneet Singh and others added 6 commits March 18, 2025 15:11
Copilot AI review requested due to automatic review settings June 4, 2025 22:09
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @andborja,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 4, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the connectedk8s extension code and test suite to add support for a new namespace parameter while standardizing the use of CLICommand. Key changes include updating CLICommmand to CLICommand across the codebase, adding a new "--kube-namespace" argument, and modifying various test and pipeline scripts accordingly.

Reviewed Changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.

File Description
testing/Test.ps1 Introduces the new kube namespace support and updates test execution logic.
testing/_params.py Adds the new "kube_namespace" argument with corresponding help text.
src/connectedk8s/azext_connectedk8s/* Refactors function signatures to use CLICommand and adjusts related proxy, helm, and diagnostic utilities.
testing/pipeline/* & .github/CODEOWNERS Updates pipeline settings and code ownership to support the changes.
Comments suppressed due to low confidence (1)

src/connectedk8s/azext_connectedk8s/_troubleshootutils.py:359

  • The variable 'diagnoser_output' is used here without any prior initialization or declaration in this function's scope, which may lead to a runtime error. Consider initializing it (e.g., as an empty list) or ensuring it is defined in the appropriate scope.
diagnoser_output.append("An exception has occured while trying to fetch the namespace pods logs from the cluster. Exception: {e}\n")

foreach ($testFile in $testFiles)
{
$resultFileNumber++
$testName = Split-Path $testFile –leaf
Copy link

Copilot AI Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dash in '–leaf' appears to be an en dash instead of a standard hyphen '-'. This might cause parsing issues; please replace it with a normal hyphen.

Suggested change
$testName = Split-Path $testFile leaf
$testName = Split-Path $testFile -leaf

Copilot uses AI. Check for mistakes.
@andborja andborja closed this Jun 4, 2025
@github-actions
Copy link

github-actions bot commented Jun 4, 2025

Hi @andborja

Release Suggestions

Module: connectedk8s

  • Please log updates into to src/connectedk8s/HISTORY.rst
  • Update VERSION to 1.11.0 in src/connectedk8s/setup.py

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants