-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[connectedk8s] Add checks for the Graytown bundle feature flag in the connectedk8s extension #8832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… connectedk8s extension
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @SherryPuffs, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
…for error messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds feature flag checks for the Graytown bundle in the connectedk8s extension, updating the connect, update, and upgrade commands. Key changes include a version bump to 1.10.8, new tests to validate the bundle feature flag behavior, and additional validations and error messages in the custom command module.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/connectedk8s/setup.py | Updates the extension version from 1.10.7 to 1.10.8 |
| src/connectedk8s/azext_connectedk8s/tests/latest/test_connectedk8s_scenario.py | Adds tests checking different bundle feature flag values and behaviors |
| src/connectedk8s/azext_connectedk8s/custom.py | Introduces functions to validate and update the bundle feature flag |
| src/connectedk8s/azext_connectedk8s/clientproxyhelper/_proxylogic.py | Corrects type reference by replacing CLICommmand with CLICommand |
| src/connectedk8s/azext_connectedk8s/_constants.py | Adds new constants related to the bundle feature flag |
| src/connectedk8s/HISTORY.rst | Updates release history for version 1.10.8 |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.