Skip to content

Conversation

@SherryPuffs
Copy link

@SherryPuffs SherryPuffs commented Jun 5, 2025

  • Add checks for the Graytown bundle feature flag in the 'connectedk8s connect' and 'connectedk8s update' commands.
  • Display a more detailed error message from the agent-update-validator in the 'connectedk8s upgrade' command.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 5, 2025 02:59
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @SherryPuffs,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 5, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

This comment was marked as outdated.

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

@SherryPuffs SherryPuffs requested a review from Copilot June 5, 2025 03:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds feature flag checks for the Graytown bundle in the connectedk8s extension, updating the connect, update, and upgrade commands. Key changes include a version bump to 1.10.8, new tests to validate the bundle feature flag behavior, and additional validations and error messages in the custom command module.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/connectedk8s/setup.py Updates the extension version from 1.10.7 to 1.10.8
src/connectedk8s/azext_connectedk8s/tests/latest/test_connectedk8s_scenario.py Adds tests checking different bundle feature flag values and behaviors
src/connectedk8s/azext_connectedk8s/custom.py Introduces functions to validate and update the bundle feature flag
src/connectedk8s/azext_connectedk8s/clientproxyhelper/_proxylogic.py Corrects type reference by replacing CLICommmand with CLICommand
src/connectedk8s/azext_connectedk8s/_constants.py Adds new constants related to the bundle feature flag
src/connectedk8s/HISTORY.rst Updates release history for version 1.10.8

@SherryPuffs SherryPuffs closed this Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants