-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update CLI description for Qumulo #8834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
@microsoft-github-policy-service agree company="Microsoft" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Qumulo CLI extension by bumping its version, raising the minimum CLI core requirement, refining command docstrings, and renaming the schema property for private IPs.
- Bump extension version to 2.1.0 and update HISTORY entry
- Raise
azext.minCliCoreVersionto 2.70.0 - Enhance docstrings across commands for clarity
- Rename
private_ipsschema property toprivate_i_ps(inconsistently)
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/qumulo/setup.py | Bumped VERSION to 2.1.0 |
| src/qumulo/azext_qumulo/azext_metadata.json | Updated azext.minCliCoreVersion to 2.70.0 |
| src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_wait.py | Refined docstring; renamed private_ips property |
| src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_show.py | Refined docstring; renamed private_ips property |
| src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_list.py | Refined docstring; renamed private_ips property in two spots |
| src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_delete.py | Refined docstring |
| src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_create.py | Refined docstring; renamed private_ips property in three spots |
| src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/__cmd_group.py | Enhanced group docstring |
| src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/__cmd_group.py | Enhanced group docstring |
| src/qumulo/azext_qumulo/aaz/latest/qumulo/__cmd_group.py | Enhanced group docstring |
| src/qumulo/HISTORY.rst | Added 2.1.0 entry and summary |
Comments suppressed due to low confidence (11)
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_wait.py:225
- [nitpick] The schema property variable
private_i_psis inconsistent. Rename it back toprivate_ipsto match the serialized name and existing conventions.
properties.private_i_ps = AAZListType(
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_wait.py:264
- [nitpick] Update this variable reference to
private_ipsto maintain consistency with the property name and avoid confusion.
private_i_ps = cls._schema_on_200.properties.private_i_ps
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_show.py:226
- [nitpick] The schema property variable
private_i_psshould be renamed toprivate_ipsfor clarity and consistency.
properties.private_i_ps = AAZListType(
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_show.py:265
- [nitpick] Change this reference back to
private_ipsso it matches the actual property name.
private_i_ps = cls._schema_on_200.properties.private_i_ps
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_list.py:229
- [nitpick] Rename
private_i_pstoprivate_ipsto align with the serialized property and existing code.
properties.private_i_ps = AAZListType(
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_list.py:268
- [nitpick] This variable should be
private_ipsinstead ofprivate_i_psto avoid confusion.
private_i_ps = cls._schema_on_200.value.Element.properties.private_i_ps
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_list.py:459
- [nitpick] Please revert the name to
private_ipsso it matches the JSON field and indexing logic.
properties.private_i_ps = AAZListType(
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_list.py:498
- [nitpick] Update this to
private_ipsto reflect the correct property naming.
private_i_ps = cls._schema_on_200.value.Element.properties.private_i_ps
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_create.py:314
- [nitpick] The local variable
private_i_psis misleading—useprivate_ipsfor consistency with the property name.
private_i_ps = _builder.get(".properties.privateIPs")
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_create.py:416
- [nitpick] Rename
private_i_psback toprivate_ipsto maintain a predictable schema property.
properties.private_i_ps = AAZListType(
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_create.py:455
- [nitpick] Change this property reference to
private_ipsto match the rest of the code and JSON contract.
private_i_ps = cls._schema_on_200_201.properties.private_i_ps
|
Hi @Avish34
|
|
@kairu-ms can you please review the PR and approve if looks good? |
1884804 to
520a8a8
Compare
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.