Skip to content

Conversation

@Avish34
Copy link
Contributor

@Avish34 Avish34 commented Jun 5, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 5, 2025 11:54
@Avish34 Avish34 requested a review from jsntcy as a code owner June 5, 2025 11:54
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 5, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@Avish34
Copy link
Contributor Author

Avish34 commented Jun 5, 2025

@Avish34 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Qumulo CLI extension by bumping its version, raising the minimum CLI core requirement, refining command docstrings, and renaming the schema property for private IPs.

  • Bump extension version to 2.1.0 and update HISTORY entry
  • Raise azext.minCliCoreVersion to 2.70.0
  • Enhance docstrings across commands for clarity
  • Rename private_ips schema property to private_i_ps (inconsistently)

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/qumulo/setup.py Bumped VERSION to 2.1.0
src/qumulo/azext_qumulo/azext_metadata.json Updated azext.minCliCoreVersion to 2.70.0
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_wait.py Refined docstring; renamed private_ips property
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_show.py Refined docstring; renamed private_ips property
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_list.py Refined docstring; renamed private_ips property in two spots
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_delete.py Refined docstring
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_create.py Refined docstring; renamed private_ips property in three spots
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/__cmd_group.py Enhanced group docstring
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/__cmd_group.py Enhanced group docstring
src/qumulo/azext_qumulo/aaz/latest/qumulo/__cmd_group.py Enhanced group docstring
src/qumulo/HISTORY.rst Added 2.1.0 entry and summary
Comments suppressed due to low confidence (11)

src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_wait.py:225

  • [nitpick] The schema property variable private_i_ps is inconsistent. Rename it back to private_ips to match the serialized name and existing conventions.
properties.private_i_ps = AAZListType(

src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_wait.py:264

  • [nitpick] Update this variable reference to private_ips to maintain consistency with the property name and avoid confusion.
private_i_ps = cls._schema_on_200.properties.private_i_ps

src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_show.py:226

  • [nitpick] The schema property variable private_i_ps should be renamed to private_ips for clarity and consistency.
properties.private_i_ps = AAZListType(

src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_show.py:265

  • [nitpick] Change this reference back to private_ips so it matches the actual property name.
private_i_ps = cls._schema_on_200.properties.private_i_ps

src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_list.py:229

  • [nitpick] Rename private_i_ps to private_ips to align with the serialized property and existing code.
properties.private_i_ps = AAZListType(

src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_list.py:268

  • [nitpick] This variable should be private_ips instead of private_i_ps to avoid confusion.
private_i_ps = cls._schema_on_200.value.Element.properties.private_i_ps

src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_list.py:459

  • [nitpick] Please revert the name to private_ips so it matches the JSON field and indexing logic.
properties.private_i_ps = AAZListType(

src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_list.py:498

  • [nitpick] Update this to private_ips to reflect the correct property naming.
private_i_ps = cls._schema_on_200.value.Element.properties.private_i_ps

src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_create.py:314

  • [nitpick] The local variable private_i_ps is misleading—use private_ips for consistency with the property name.
private_i_ps = _builder.get(".properties.privateIPs")

src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_create.py:416

  • [nitpick] Rename private_i_ps back to private_ips to maintain a predictable schema property.
properties.private_i_ps = AAZListType(

src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_create.py:455

  • [nitpick] Change this property reference to private_ips to match the rest of the code and JSON contract.
private_i_ps = cls._schema_on_200_201.properties.private_i_ps

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

Hi @Avish34

⚠️ Release Requirements

Module: qumulo

  • ⚠️ Please update VERSION to be 2.0.1 in src/qumulo/setup.py

Notes

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 5, 2025
@yonzhan yonzhan requested a review from kairu-ms June 5, 2025 14:24
@Avish34
Copy link
Contributor Author

Avish34 commented Jun 10, 2025

@kairu-ms can you please review the PR and approve if looks good?

@Avish34 Avish34 force-pushed the qumulo-cli-refresh branch from 1884804 to 520a8a8 Compare June 10, 2025 05:20
@Avish34 Avish34 closed this Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants