Skip to content

Conversation

@jamesvoongms
Copy link
Member

@jamesvoongms jamesvoongms commented Jun 9, 2025


PR adds changes from the 2023-07-01-preview specification to 2025-05-01

Notably it adds a new POST request into the domain list resource to allow customers to create larger domain list
It also removes the BlockResponseCode from the DNS Security Rule object

Corresponding AAZ PR:
Azure/aaz#777

2025-05-01 Spec PR:
Azure/azure-rest-api-specs#34869

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 9, 2025 05:23
@jamesvoongms jamesvoongms requested a review from necusjz as a code owner June 9, 2025 05:23
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 9, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️dns-resolver
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd dns-resolver domain-list bulk cmd dns-resolver domain-list bulk added
⚠️ 1009 - ParaPropRemove dns-resolver domain-list create cmd dns-resolver domain-list create update parameter domains: removed property required=True

@azure-client-tools-bot-prd
Copy link

Hi @jamesvoongms,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 9, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

@yonzhan yonzhan requested a review from jsntcy June 9, 2025 05:39
@jamesvoongms
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8840 in repo Azure/azure-cli-extensions

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 9, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz
Copy link
Member

necusjz commented Jun 10, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz
Copy link
Member

necusjz commented Jun 10, 2025

Hi @jamesvoongms

Release Suggestions

Module: dns-resolver

  • Update VERSION to 1.1.0 in src/dns-resolver/setup.py

Notes

@jamesvoongms i have to say, u didn't update setup.py; it will cause no release be triggered.

@jamesvoongms
Copy link
Member Author

Thanks @necusjz , i missed that, have updated the version in setup.py now!

@jamesvoongms
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8840 in repo Azure/azure-cli-extensions

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 11, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz necusjz merged commit 2af48ef into Azure:main Jun 12, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ dns-resolver-1.1.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=127026613&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants