Skip to content

Conversation

@evelyn-ys
Copy link
Member

To support Azure/azure-cli#31066


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 9, 2025 09:08
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 9, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 9, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the version of the AEM extension and removes the msrestazure dependency, replacing it with azure core and azure mgmt core tools.

  • Version bump from 0.3.0 to 0.3.1
  • Replaced msrestazure imports and exception handling with their azure counterparts
  • Updated HISTORY.rst to document the changes

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/aem/setup.py Updated version number
src/aem/azext_aem/custom.py Updated exception handling and dependency imports
src/aem/HISTORY.rst Documented the new version and changes
Comments suppressed due to low confidence (1)

src/aem/azext_aem/custom.py:268

  • Ensure that the unconditional re-raising of HttpResponseError is the intended behavior after replacing CloudError. If conditional handling for principal not found errors is required, consider replicating a similar check for HttpResponseError based on its error structure.
except HttpResponseError as cex:

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 9, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 9, 2025
@yonzhan yonzhan requested a review from jiasli June 9, 2025 10:09
Comment on lines +5 to +7
1.0.0
+++++
* Remove msrestazure dependency
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Releasing it as 1.0.0 will assign a major version which has semantic versioning implications. Can we use 0.3.1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if ((not cex.error) or (not cex.error.error) or
(PRINCIPAL_NOT_FOUND_ERROR != cex.error.error.lower())):
if ((not cex.error) or (not cex.error.code) or
(PRINCIPAL_NOT_FOUND_ERROR != cex.error.code.lower())):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If principalType (--assignee-principal-type in az role assignment create) is provided, creating role assignment won't fail at all.

I tested with a non-existing assignee without principalType and verified the cex.error.code is indeed PrincipalNotFound:

az role assignment create --role Contributor --assignee-object-id 8ada7388-5e1f-4455-8693-909abcc039d2 --scope /subscriptions/xxx

image

@yanzhudd
Copy link
Contributor

The failed tests have been rerun in the PR: #8859

@evelyn-ys evelyn-ys merged commit 4597134 into Azure:main Jun 13, 2025
28 of 30 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aem-1.0.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=127178233&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants