Skip to content

Conversation

@poshett
Copy link
Contributor

@poshett poshett commented Jun 9, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 9, 2025 10:07
@poshett poshett requested review from jsntcy and kairu-ms as code owners June 9, 2025 10:07
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 9, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @poshett,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 9, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the descriptions of Elastic monitor and related commands by refining the docstrings to provide clearer, more detailed information about each command’s purpose and behavior.

  • Updated command docstrings for clearer descriptions and enhanced consistency across the module.
  • Improved guidance on command usage to better support network traffic control and monitoring functionalities.
  • Expanded documentation in examples to aid in audit and management of Elastic resources.

Reviewed Changes

Copilot reviewed 50 out of 50 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/elastic/azext_elastic/aaz/latest/elastic/monitor/_list_all_traffic_filter.py Updated docstring to clarify filter listing functionality.
src/elastic/azext_elastic/aaz/latest/elastic/monitor/_list.py Enhanced description of monitor listing capabilities.
src/elastic/azext_elastic/aaz/latest/elastic/monitor/_get_billing_info.py Refined docstring to detail billing info retrieval.
src/elastic/azext_elastic/aaz/latest/elastic/monitor/_detach_traffic_filter.py Improved docstring for traffic filter detachment.
src/elastic/azext_elastic/aaz/latest/elastic/monitor/_detach_and_delete_traffic_filter.py Updated description for combined detach and delete functionality.
src/elastic/azext_elastic/aaz/latest/elastic/monitor/_delete_traffic_filter.py Clarified functionality for deleting traffic filters.
src/elastic/azext_elastic/aaz/latest/elastic/monitor/_delete.py Enhanced clarity in the description of monitor deletion.
src/elastic/azext_elastic/aaz/latest/elastic/monitor/_create_or_update_external_user.py Provided more details on external user configuration creation/updating.
src/elastic/azext_elastic/aaz/latest/elastic/monitor/_create_and_associate_pl_filter.py Refined instruction for creating and associating PL filters.
src/elastic/azext_elastic/aaz/latest/elastic/monitor/_create_and_associate_ip_filter.py Improved docstring for IP filter association.
src/elastic/azext_elastic/aaz/latest/elastic/monitor/_create.py Updated and expanded description for monitor creation.
src/elastic/azext_elastic/aaz/latest/elastic/monitor/_associate_traffic_filter.py Clarified association of traffic filters with monitors.
src/elastic/azext_elastic/aaz/latest/elastic/monitor/__cmd_group.py Expanded group description for managing Elastic monitors.
src/elastic/azext_elastic/aaz/latest/elastic/get/elastic/organization_to_azure/subscription/_mapping.py Updated to clearly describe the mapping details retrieval.
src/elastic/azext_elastic/aaz/latest/elastic/get/elastic/organization_to_azure/subscription/__cmd_group.py Refined group description for subscription mapping.
src/elastic/azext_elastic/aaz/latest/elastic/get/elastic/organization_to_azure/__cmd_group.py Enhanced clarity of managing organization-to-Azure details.
src/elastic/azext_elastic/aaz/latest/elastic/get/elastic/__cmd_group.py Clarified the command group purpose for retrieving Elastic details.
src/elastic/azext_elastic/aaz/latest/elastic/get/__cmd_group.py Improved description for retrieving detailed Elastic information.
src/elastic/azext_elastic/aaz/latest/elastic/elastic_version/__cmd_group.py Expanded description to detail available Elastic versions.
src/elastic/azext_elastic/aaz/latest/elastic/_get_organization_api_key.py Refined wording for fetching the organization API key.

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

Hi @poshett

Release Suggestions

Module: elastic

  • Please log updates into to src/elastic/HISTORY.rst
  • Update VERSION to 1.0.0b4 in src/elastic/setup.py

Notes

@poshett
Copy link
Contributor Author

poshett commented Jun 12, 2025

Hello @kairu-ms , @yonzhan - Kindly let us know if anything more needs to be done OR if this is good to be merged.
The intent of the PR is to update the API descriptions to a more user-friendly manner.

@poshett
Copy link
Contributor Author

poshett commented Jun 17, 2025

Hello @kairu-ms , @yonzhan - Any updates here?

@poshett
Copy link
Contributor Author

poshett commented Jun 18, 2025

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8843 in repo Azure/azure-cli-extensions

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 18, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@poshett
Copy link
Contributor Author

poshett commented Jun 18, 2025

@yonzhan , @kairu-ms

Could you please help in understanding if the ITs/builds failures are genuine?

The only changes made as part of this PR are to update the descriptions of a few APIs and I am unable to spot any errors around it in the pipeline failures.

Requesting your kind attention here.

@poshett
Copy link
Contributor Author

poshett commented Jun 23, 2025

@yonzhan , @kairu-ms - The pipelines are failing despite updating the test recordings (which ran successfully locally).
Looks like the failures are for updated descriptions - which are intended changes of this PR.
Requesting your help here.

kairu-ms
kairu-ms previously approved these changes Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants