-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Session Code Execute] Extend maximum supported value of --timeout-in-seconds from 60 to 180
#8844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @bowen5, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extends the supported session code execution timeout from 60 to 180 seconds.
- Updated validator to allow a maximum of 180 seconds.
- Adjusted CLI parameter help text to reflect the new range.
- Added a changelog entry and bumped the version in HISTORY.rst.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/containerapp/azext_containerapp/_validators.py | Extended max timeout check from 60 to 180 seconds |
| src/containerapp/azext_containerapp/_params.py | Updated help string to show 0–180 seconds |
| src/containerapp/HISTORY.rst | Added 1.2.0b2 release note for the timeout extension |
Comments suppressed due to low confidence (1)
src/containerapp/azext_containerapp/_validators.py:222
- Add or update unit tests to cover the new upper bound (180 seconds) and ensure values above 180 correctly raise a ValidationError.
if timeout_in_seconds < 0 or timeout_in_seconds > 180:
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @bowen5 Release SuggestionsModule: containerapp
Notes
|
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp session code-interpreter executeGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.