Skip to content

Conversation

@bowen5
Copy link
Contributor

@bowen5 bowen5 commented Jun 10, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp session code-interpreter execute

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 10, 2025 02:45
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @bowen5,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 10, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the supported session code execution timeout from 60 to 180 seconds.

  • Updated validator to allow a maximum of 180 seconds.
  • Adjusted CLI parameter help text to reflect the new range.
  • Added a changelog entry and bumped the version in HISTORY.rst.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/containerapp/azext_containerapp/_validators.py Extended max timeout check from 60 to 180 seconds
src/containerapp/azext_containerapp/_params.py Updated help string to show 0–180 seconds
src/containerapp/HISTORY.rst Added 1.2.0b2 release note for the timeout extension
Comments suppressed due to low confidence (1)

src/containerapp/azext_containerapp/_validators.py:222

  • Add or update unit tests to cover the new upper bound (180 seconds) and ensure values above 180 correctly raise a ValidationError.
if timeout_in_seconds < 0 or timeout_in_seconds > 180:

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

Hi @bowen5

Release Suggestions

Module: containerapp

  • Update VERSION to 1.2.0b2 in src/containerapp/setup.py

Notes

@zhoxing-ms zhoxing-ms merged commit 22a6ce5 into Azure:main Jun 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants