Skip to content

Conversation

@evelyn-ys
Copy link
Member

To support Azure/azure-cli#31066


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 10, 2025 07:37
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 10, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 10, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes the msrestazure dependency from the AMG extension by switching the parse_resource_id import and bumping the version.

  • Bumped extension version to 2.6.1
  • Swapped import of parse_resource_id from msrestazure.tools to azure.mgmt.core.tools
  • Updated HISTORY.rst to document the removal of msrestazure

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/amg/setup.py Version bumped from 2.6.0 to 2.6.1
src/amg/azext_amg/_validators.py Replaced msrestazure.tools.parse_resource_id import
src/amg/HISTORY.rst Added 2.6.1 entry and noted removal of msrestazure
Comments suppressed due to low confidence (2)

src/amg/azext_amg/_validators.py:6

  • [nitpick] Add or update unit tests to cover the validator logic using this new parse_resource_id import to prevent regressions.
from azure.mgmt.core.tools import parse_resource_id

src/amg/setup.py:19

  • Ensure that msrestazure is removed from install_requires and that azure-mgmt-core is added so the new import of parse_resource_id resolves correctly.
VERSION = '2.6.1'

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@yonzhan yonzhan requested a review from jiasli June 10, 2025 07:41
@github-actions
Copy link

@evelyn-ys evelyn-ys merged commit 22eafc6 into Azure:main Jun 11, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ amg-2.6.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=126927251&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants