-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Session Code Execute] Extend maximum supported value of --timeout-in-seconds from 180 to 220 #8853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @bowen5, |
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR increases the maximum allowable timeout for the code-interpreter session command from 180 to 240 seconds, renames the validator to reflect “session” context, and updates related help text and changelog.
- Renamed
validate_timeout_in_secondstovalidate_session_timeout_in_secondsand adjusted its range check from inclusive 0–180 to 1–240. - Updated the
--timeout-in-secondsargument’s help to reflect the new 1–240 range. - Updated
HISTORY.rstto document the extended timeout limit.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| _validators.py | Renamed validator function and adjusted allowed range. |
| _params.py | Swapped in the new validator name and updated help. |
| HISTORY.rst | Updated release notes to show timeout increased to 240. |
Comments suppressed due to low confidence (2)
src/containerapp/azext_containerapp/_params.py:486
- [nitpick] The help string could be clearer and match the range syntax used elsewhere. For example: "Duration in seconds that code can run in the session before timing out (range: 1–240), e.g., 30."
c.argument('timeout_in_seconds', type=int, validator=validate_session_timeout_in_seconds, default=60, help="Duration in seconds code in session can run prior to timing out 1 - 240 secs, e.g. 30")
src/containerapp/azext_containerapp/_validators.py:219
- Since the valid range was extended, consider adding unit tests to cover the new upper bound (240 seconds) and the exclusion of zero.
def validate_session_timeout_in_seconds(cmd, namespace):
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @bowen5 Release SuggestionsModule: containerapp
Notes
|
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp session code-interpreter executeGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.