Skip to content

Conversation

@bowen5
Copy link
Contributor

@bowen5 bowen5 commented Jun 11, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp session code-interpreter execute

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 11, 2025 04:26
@azure-client-tools-bot-prd
Copy link

Hi @bowen5,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 11, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 11, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the maximum allowable timeout for the code-interpreter session command from 180 to 240 seconds, renames the validator to reflect “session” context, and updates related help text and changelog.

  • Renamed validate_timeout_in_seconds to validate_session_timeout_in_seconds and adjusted its range check from inclusive 0–180 to 1–240.
  • Updated the --timeout-in-seconds argument’s help to reflect the new 1–240 range.
  • Updated HISTORY.rst to document the extended timeout limit.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
_validators.py Renamed validator function and adjusted allowed range.
_params.py Swapped in the new validator name and updated help.
HISTORY.rst Updated release notes to show timeout increased to 240.
Comments suppressed due to low confidence (2)

src/containerapp/azext_containerapp/_params.py:486

  • [nitpick] The help string could be clearer and match the range syntax used elsewhere. For example: "Duration in seconds that code can run in the session before timing out (range: 1–240), e.g., 30."
        c.argument('timeout_in_seconds', type=int, validator=validate_session_timeout_in_seconds, default=60, help="Duration in seconds code in session can run prior to timing out 1 - 240 secs, e.g. 30")

src/containerapp/azext_containerapp/_validators.py:219

  • Since the valid range was extended, consider adding unit tests to cover the new upper bound (240 seconds) and the exclusion of zero.
def validate_session_timeout_in_seconds(cmd, namespace):

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

Hi @bowen5

Release Suggestions

Module: containerapp

  • Update VERSION to 1.2.0b2 in src/containerapp/setup.py

Notes

@bowen5 bowen5 changed the title [Session Code Execute] Extend maximum supported value of --timeout-in-seconds from 180 to 240 [Session Code Execute] Extend maximum supported value of --timeout-in-seconds from 180 to 220 Jun 13, 2025
@zhoxing-ms zhoxing-ms merged commit b8c3eca into Azure:main Jun 16, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants