Skip to content

Conversation

@lasuredd-msft
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Adding new extension azure-data-transfer and commands to support connection and flow operations.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 11, 2025 09:38
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @lasuredd-msft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 11, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds the new azure-data-transfer Azure CLI extension with commands for managing data transfer pipelines, connections, and flows.

  • Introduces the extension loader and command registration for azure-data-transfer.
  • Implements AAZ-based commands for connection operations (create, list, show, delete, link, wait, list-pending).
  • Implements AAZ-based commands for flow operations under each connection (create, list, show, link, enable, disable, update).
  • Provides parameter definitions, help text, README, and initial release history.

Reviewed Changes

Copilot reviewed 54 out of 54 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/azure-data-transfer/azext_azure_data_transfer/_params.py Defines CLI parameters for pipeline and flow commands
src/azure-data-transfer/azext_azure_data_transfer/_help.py Adds help strings and examples for new commands
src/azure-data-transfer/azext_azure_data_transfer/init.py Registers the extension’s command loader
src/azure-data-transfer/README.md Documents installation and usage examples
src/azure-data-transfer/HISTORY.rst Adds initial release history for the extension
src/azure-data-transfer/azext_azure_data_transfer/aaz/init.py Initializes AAZ support package
src/azure-data-transfer/azext_azure_data_transfer/aaz/latest/init.py Initializes latest AAZ commands package
src/azure-data-transfer/azext_azure_data_transfer/aaz/latest/azure_data_transfer/__cmd_group.py Registers top-level azure-data-transfer command group
src/azure-data-transfer/azext_azure_data_transfer/aaz/latest/azure_data_transfer/init.py Imports top-level command group
src/azure-data-transfer/azext_azure_data_transfer/aaz/latest/azure_data_transfer/connection/__cmd_group.py Registers connection command group
src/azure-data-transfer/azext_azure_data_transfer/aaz/latest/azure_data_transfer/connection/init.py Imports connection command modules
src/azure-data-transfer/azext_azure_data_transfer/aaz/latest/azure_data_transfer/connection/_list.py Implements connection list command
src/azure-data-transfer/azext_azure_data_transfer/aaz/latest/azure_data_transfer/connection/_show.py Implements connection show command
src/azure-data-transfer/azext_azure_data_transfer/aaz/latest/azure_data_transfer/connection/_delete.py Implements connection delete command
src/azure-data-transfer/azext_azure_data_transfer/aaz/latest/azure_data_transfer/connection/_link.py Implements connection link command
src/azure-data-transfer/azext_azure_data_transfer/aaz/latest/azure_data_transfer/connection/_wait.py Implements connection wait command
src/azure-data-transfer/azext_azure_data_transfer/aaz/latest/azure_data_transfer/connection/_list_pending_connection.py Implements connection list-pending-connection command
src/azure-data-transfer/azext_azure_data_transfer/aaz/latest/azure_data_transfer/connection/_list_pending_flow.py Implements connection list-pending-flow command
src/azure-data-transfer/azext_azure_data_transfer/aaz/latest/azure_data_transfer/connection/flow/__cmd_group.py Registers connection flow command group
src/azure-data-transfer/azext_azure_data_transfer/aaz/latest/azure_data_transfer/connection/flow/init.py Imports flow command modules
src/azure-data-transfer/azext_azure_data_transfer/aaz/latest/azure_data_transfer/connection/flow/_link.py Implements connection flow link command
src/azure-data-transfer/azext_azure_data_transfer/aaz/latest/azure_data_transfer/connection/flow/_create.py Implements connection flow create command
src/azure-data-transfer/azext_azure_data_transfer/aaz/latest/azure_data_transfer/connection/flow/_list.py Implements connection flow list command
src/azure-data-transfer/azext_azure_data_transfer/azext_azure_data_transfer/init.py Defines the CLI commands loader
Comments suppressed due to low confidence (3)

src/azure-data-transfer/azext_azure_data_transfer/aaz/latest/azure_data_transfer/connection/_list_pending_flow.py:49

  • The --connection-name argument is missing the short alias (-n/--name). Consider adding -n and --name to match other commands and improve discoverability.
_args_schema.connection_name = AAZStrArg(options=["--connection-name"],

src/azure-data-transfer/azext_azure_data_transfer/aaz/latest/azure_data_transfer/connection/flow/_link.py:69

  • In the flow link command, the argument is named pending_connection_id. To avoid confusion with the connection-level link, rename this to pending_flow_id (and --pending-flow-id) so it clearly refers to a flow.
_args_schema.pending_connection_id = AAZStrArg(

src/azure-data-transfer/README.md:105

  • The example for listing connections uses connection link. It should be az azure-data-transfer connection list to match the command being demonstrated.
az azure-data-transfer connection link \

@github-actions
Copy link

github-actions bot commented Jun 11, 2025

@yonzhan yonzhan requested a review from kairu-ms June 11, 2025 11:21
@yonzhan yonzhan requested a review from jsntcy June 11, 2025 11:22
Release History
===============

1.0.0b1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we starting with 1.x here? I thought we would need to keep sem-ver below 1 for private preview: e.g. - 0.1.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minimum product for release is 1.x, extensions in preview have 1.xbx, once we move out of preview then the version number starts from 1.x.

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 13, 2025
@lasuredd-msft lasuredd-msft force-pushed the azure-data-transfer branch 2 times, most recently from 66f2457 to 6ac3c34 Compare June 13, 2025 08:04
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 13, 2025
@necusjz
Copy link
Member

necusjz commented Jun 16, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz
Copy link
Member

necusjz commented Jun 16, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz
Copy link
Member

necusjz commented Jun 16, 2025

@lasuredd-msft is it ready for release?

@lasuredd-msft
Copy link
Contributor Author

@lasuredd-msft is it ready for release?

Yes @necusjz PR is ready for review.

##### Get a pipeline

```
az azure-data-transfer pipeline show \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think az azure-data-transfer xx is a good name? cauz, az and azure-* have the duplicate meaning here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved away from the duplicate azure naming , renamed to data-transfer

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8854 in repo Azure/azure-cli-extensions

@necusjz
Copy link
Member

necusjz commented Jun 18, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@lasuredd-msft lasuredd-msft requested a review from necusjz June 19, 2025 03:04
@necusjz
Copy link
Member

necusjz commented Jun 19, 2025

plz provide the link of your pull request in Azure/aaz, thank you.

@lasuredd-msft
Copy link
Contributor Author

plz provide the link of your pull request in Azure/aaz, thank you.

AAZ repo PR link : Azure/aaz#785

@lasuredd-msft lasuredd-msft requested a review from necusjz June 20, 2025 09:15
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 21, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 21, 2025
@necusjz
Copy link
Member

necusjz commented Jun 23, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz necusjz merged commit e5e27dc into Azure:main Jun 23, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ data-transfer-1.0.0b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=128087626&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants