Skip to content

Conversation

@matthchr
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create and az aks update

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 12, 2025 00:20
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 12, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter node_provisioning_default_pools
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter node_provisioning_default_pools

@azure-client-tools-bot-prd
Copy link

Hi @matthchr,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 12, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the new parameter --node-provisioning-default-pools to both the az aks create and update commands.

  • Introduces updated tests in test_managed_cluster_decorator.py to verify behavior for unset, "Auto", and "None" values.
  • Adds corresponding helper functions in managed_cluster_decorator.py, updates parameter definitions in _params.py, defines new constants in _consts.py, and documents the changes in HISTORY.rst.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py Added tests for node provisioning profile including cases for default pools.
src/aks-preview/azext_aks_preview/managed_cluster_decorator.py Added getter and setter methods for node_provisioning_default_pools in create and update flows.
src/aks-preview/azext_aks_preview/_params.py Introduced new enum values and argument definition for --node-provisioning-default-pools.
src/aks-preview/azext_aks_preview/_consts.py Defined new constants for default pools ("Auto" and "None").
src/aks-preview/HISTORY.rst Updated changelog to reflect the addition of the new parameter.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

github-actions bot commented Jun 12, 2025

Hi @matthchr

Release Suggestions

Module: aks-preview

  • Update VERSION to 18.0.0b14 in src/aks-preview/setup.py

Notes

@matthchr matthchr force-pushed the matthchr/nap-default-pools branch from e3675db to e47815a Compare June 12, 2025 00:32
@matthchr
Copy link
Member Author

whoops forgot to push the style fixes - pushed now

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change looks good to me, it is recommended to add a scenario test for the new feature. You can refer to the existing examples in test_aks_commands.py.

@matthchr matthchr force-pushed the matthchr/nap-default-pools branch from e47815a to 3314bd2 Compare June 16, 2025 16:25
@matthchr matthchr force-pushed the matthchr/nap-default-pools branch from 3314bd2 to f5ac85c Compare June 16, 2025 16:27
@matthchr
Copy link
Member Author

Added test scenarios, added help text (missed previously), and fixed a few other minor issues. Should be good to merge now.

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change.

  • test_aks_create_node_provisioning_profile
  • test_aks_update_node_provisioning_profile

@yanzhudd yanzhudd merged commit a6de7cc into Azure:main Jun 17, 2025
24 checks passed
@matthchr matthchr deleted the matthchr/nap-default-pools branch June 17, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants