Skip to content

Conversation

@anandgmenon
Copy link
Contributor

@anandgmenon anandgmenon commented Jun 12, 2025

… Openshift on Arc


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 12, 2025 04:12
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 12, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1010 - ParaPropUpdate containerapp arc setup-core-dns cmd containerapp arc setup-core-dns update parameter distro: updated property choices from ['AksAzureLocal'] to ['AksAzureLocal', 'openshift']

@azure-client-tools-bot-prd
Copy link

Hi @anandgmenon,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 12, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for custom CoreDNS setup for OpenShift clusters alongside the existing AKS support.

  • Adds OpenShift-specific constants and logic to create and patch CoreDNS resources.
  • Introduces new functions in _arc_utils.py for managing deployments, config maps, and DNS operator configurations on OpenShift.
  • Updates CLI parameter definitions to include OpenShift as a supported distro.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/containerapp/azext_containerapp/custom.py Adds OpenShift branch in setup_core_dns and related logging/error handling.
src/containerapp/azext_containerapp/_params.py Updates CLI argument to include OpenShift distro with a minor typo in the help text.
src/containerapp/azext_containerapp/_constants.py Introduces new constants for OpenShift support.
src/containerapp/azext_containerapp/_arc_utils.py Adds multiple helper functions for creating/updating resources and patching DNS operator for OpenShift.
Comments suppressed due to low confidence (1)

src/containerapp/azext_containerapp/_arc_utils.py:637

  • [nitpick] The error message appears counterintuitive; consider rephrasing it to indicate that the required key is missing (e.g., "'k4apps-default.io.server' key not found in the coredns-custom ConfigMap in kube-system namespace.").
raise ValidationError("'k4apps-default.io.server' key found in the coredns-custom ConfigMap in kube-system namespace.")

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Jun 12, 2025

@Juliehzl
Copy link
Contributor

Juliehzl commented Jul 1, 2025

Please also update history.rst with releasee note for the feature. In addition, do you want to release the feature? If yes, please update version in setup.py

@zhoxing-ms zhoxing-ms changed the title [Containerapp]: az containerapp arc: Enable setup custom core dns for Openshift [Containerapp] az containerapp arc: Enable setup custom core dns for Openshift Jul 2, 2025
@zhoxing-ms
Copy link
Contributor

Could you please add some test cases for these PR changes?

@anandgmenon
Copy link
Contributor Author

Could you please add some test cases for these PR changes?

These changes are specifically targeted for container apps on arc for openshift cluster. Hence adding testcases for the same will need a openshift cluster which can be tricky. Wondering if we can skip them here

@zhoxing-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@zhoxing-ms zhoxing-ms merged commit 41299b9 into Azure:main Jul 14, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ containerapp ] : https://dev.azure.com/msazure/One/_build/results?buildId=130273726&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants