Skip to content

Conversation

@nddq
Copy link
Member

@nddq nddq commented Jun 16, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

image

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 16, 2025 23:57
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 16, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 16, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a null-pointer exception when setting the ACNS transit encryption flag by instantiating the proper model, updates the extension version, and adds tests to cover the new behavior.

  • Bumped extension version to 18.0.0b14
  • Added end-to-end tests for create/update commands with --acns-transit-encryption-type and --acns-advanced-networkpolicies
  • Changed direct property assignment to use AdvancedNetworkingSecurityTransitEncryption in the decorator to avoid NPE

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

File Description
src/aks-preview/setup.py Bumped version from 18.0.0b13 to 18.0.0b14
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Added tests for ACNS transit encryption and advanced network policies
src/aks-preview/azext_aks_preview/managed_cluster_decorator.py Switched to instantiating AdvancedNetworkingSecurityTransitEncryption instead of direct property assignment
src/aks-preview/HISTORY.rst Documented the NPE fix under version 18.0.0b14

@github-actions
Copy link

github-actions bot commented Jun 17, 2025

@yanzhudd
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd
Copy link
Contributor

Hi @FumingZhang
could you please help to review this PR as well?

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I’m still unable to validate the cases via live test because the test subscription lacks the required preview feature registration.

Does the feature support validation through the AKSHTTPCustomFeatures header on the server side? If so, please add the corresponding custom header in the test code.

@yanzhudd
Copy link
Contributor

please fix the CI issues.

@nddq
Copy link
Member Author

nddq commented Jun 17, 2025

@yanzhudd should be fixed now

@nddq
Copy link
Member Author

nddq commented Jun 17, 2025

lgtm

I’m still unable to validate the cases via live test because the test subscription lacks the required preview feature registration.

Does the feature support validation through the AKSHTTPCustomFeatures header on the server side? If so, please add the corresponding custom header in the test code.

@FumingZhang i tried adding that option, can you try running it again?

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requeued live test, test passed!

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang
FumingZhang previously approved these changes Jun 18, 2025
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 18, 2025
@nddq nddq requested a review from FumingZhang June 18, 2025 03:25
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 18, 2025
@yanzhudd
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd yanzhudd merged commit 499e11d into Azure:main Jun 18, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview-18.0.0b15 ] : https://dev.azure.com/msazure/One/_build/results?buildId=127626885&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants