-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix(acns): npe issue for acns transit encryption flag #8867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a null-pointer exception when setting the ACNS transit encryption flag by instantiating the proper model, updates the extension version, and adds tests to cover the new behavior.
- Bumped extension version to 18.0.0b14
- Added end-to-end tests for create/update commands with
--acns-transit-encryption-typeand--acns-advanced-networkpolicies - Changed direct property assignment to use
AdvancedNetworkingSecurityTransitEncryptionin the decorator to avoid NPE
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/aks-preview/setup.py | Bumped version from 18.0.0b13 to 18.0.0b14 |
| src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py | Added tests for ACNS transit encryption and advanced network policies |
| src/aks-preview/azext_aks_preview/managed_cluster_decorator.py | Switched to instantiating AdvancedNetworkingSecurityTransitEncryption instead of direct property assignment |
| src/aks-preview/HISTORY.rst | Documented the NPE fix under version 18.0.0b14 |
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Hi @FumingZhang |
FumingZhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I’m still unable to validate the cases via live test because the test subscription lacks the required preview feature registration.
Does the feature support validation through the AKSHTTPCustomFeatures header on the server side? If so, please add the corresponding custom header in the test code.
|
please fix the CI issues. |
|
@yanzhudd should be fixed now |
@FumingZhang i tried adding that option, can you try running it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requeued live test, test passed!
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Signed-off-by: Quang Nguyen <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ aks-preview-18.0.0b15 ] : https://dev.azure.com/msazure/One/_build/results?buildId=127626885&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.