Skip to content

Conversation

@xmzhao0822
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks namespace

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 17, 2025 20:15
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 17, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1003 - CmdPropAdd aks namespace add cmd aks namespace add added property is_preview
⚠️ 1003 - CmdPropAdd aks namespace delete cmd aks namespace delete added property is_preview
⚠️ 1003 - CmdPropAdd aks namespace get-credentials cmd aks namespace get-credentials added property is_preview
⚠️ 1003 - CmdPropAdd aks namespace list cmd aks namespace list added property is_preview
⚠️ 1003 - CmdPropAdd aks namespace show cmd aks namespace show added property is_preview
⚠️ 1003 - CmdPropAdd aks namespace update cmd aks namespace update added property is_preview

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces a preview flag for the managed namespace feature in the AKS extension to enable early testing of new functionality.

  • Bumps the extension version in setup.py to 18.0.0b14.
  • Adds the preview flag (is_preview=True) for the "aks namespace" command in commands.py.
  • Updates the HISTORY.rst file to document the new preview flag.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/aks-preview/setup.py Updated version number to reflect new preview release
src/aks-preview/azext_aks_preview/commands.py Added is_preview=True for the new namespace command
src/aks-preview/HISTORY.rst Updated release notes to include the preview flag

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 17, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yanzhudd yanzhudd merged commit dddc6c9 into Azure:main Jun 18, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview-18.0.0b14 ] : https://dev.azure.com/msazure/One/_build/results?buildId=127609486&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants