-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{AKS} add preview flag to feature managed namespace #8872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks namespace add | cmd aks namespace add added property is_preview |
||
| aks namespace delete | cmd aks namespace delete added property is_preview |
||
| aks namespace get-credentials | cmd aks namespace get-credentials added property is_preview |
||
| aks namespace list | cmd aks namespace list added property is_preview |
||
| aks namespace show | cmd aks namespace show added property is_preview |
||
| aks namespace update | cmd aks namespace update added property is_preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces a preview flag for the managed namespace feature in the AKS extension to enable early testing of new functionality.
- Bumps the extension version in setup.py to 18.0.0b14.
- Adds the preview flag (is_preview=True) for the "aks namespace" command in commands.py.
- Updates the HISTORY.rst file to document the new preview flag.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/aks-preview/setup.py | Updated version number to reflect new preview release |
| src/aks-preview/azext_aks_preview/commands.py | Added is_preview=True for the new namespace command |
| src/aks-preview/HISTORY.rst | Updated release notes to include the preview flag |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
FumingZhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
[Release] Update index.json for extension [ aks-preview-18.0.0b14 ] : https://dev.azure.com/msazure/One/_build/results?buildId=127609486&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks namespace
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.