Skip to content

Conversation

@HE-Xinyu
Copy link
Contributor

@HE-Xinyu HE-Xinyu commented Jun 18, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 18, 2025 07:05
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @HE-Xinyu,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 18, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the help documentation for the load-balancer update command by refining the existing example and adding a new one for IP address updates.

  • Clarified the advertise mode example.
  • Introduced an example showing how to update load balancer IP addresses.
Comments suppressed due to low confidence (2)

src/k8s-runtime/azext_k8s_runtime/aaz/latest/k8s_runtime/load_balancer/_update.py:21

  • The example command is indented inconsistently; please use a uniform indentation (e.g., 8 spaces) for all example command lines under :example: to ensure proper formatting in the generated help.
        az k8s-runtime load-balancer update --load-balancer-name testlb1 --resource-uri subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/example/providers/Microsoft.Kubernetes/connectedClusters/cluster1 --advertise-mode ARP

src/k8s-runtime/azext_k8s_runtime/aaz/latest/k8s_runtime/load_balancer/_update.py:23

  • [nitpick] Consider aligning the example title with the parameter name by using "IP addresses" (plural) to match the --addresses argument.
    :example: Update a load balancer IP address

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

Hi @HE-Xinyu

Release Suggestions

Module: k8s-runtime

  • Please log updates into to src/k8s-runtime/HISTORY.rst
  • Update VERSION to 2.0.1 in src/k8s-runtime/setup.py

Notes

@zhoxing-ms zhoxing-ms merged commit 4e361b1 into Azure:main Jun 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants