Skip to content

Conversation

@Avish34
Copy link
Contributor

@Avish34 Avish34 commented Jun 19, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 19, 2025 10:24
@Avish34 Avish34 requested a review from jsntcy as a code owner June 19, 2025 10:24
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 19, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @Avish34,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 19, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Qumulo CLI extension by bumping the minimum CLI core version, refining command and group descriptions, and renaming an internal property related to private IPs.

  • Bumped azext.minCliCoreVersion from 2.61.0 to 2.70.0
  • Refined docstrings for create, show, list, delete commands and command groups
  • Renamed the private_ips property to private_i_ps in several AAZ schema builders

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/qumulo/azext_qumulo/azext_metadata.json Updated minimum CLI core version
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_wait.py Renamed private_ips to private_i_ps in schema
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_show.py Renamed private_ips to private_i_ps and updated docstring
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_list.py Renamed private_ips to private_i_ps and updated docstring
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_delete.py Updated delete command docstring
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_create.py Renamed private_ips to private_i_ps and updated docstring
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/__cmd_group.py Updated command group docstring
src/qumulo/azext_qumulo/aaz/latest/qumulo/__cmd_group.py Updated top-level command group docstring
Comments suppressed due to low confidence (4)

src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_wait.py:225

  • It looks like private_i_ps is a typo of private_ips. Renaming back to private_ips will keep the property consistent with the serialized name and other references.
            properties.private_i_ps = AAZListType(

src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_show.py:226

  • The property name private_i_ps appears to be a typo. It should be private_ips to match the serialized field and other implementations.
            properties.private_i_ps = AAZListType(

src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_list.py:229

  • Renaming this back to private_ips will maintain consistency with the schema and avoid breaking references elsewhere.
            properties.private_i_ps = AAZListType(

src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_create.py:416

  • This appears to be an unintended rename. Please revert to private_ips so it aligns with the serialized JSON field and existing code references.
            properties.private_i_ps = AAZListType(

@github-actions
Copy link

github-actions bot commented Jun 19, 2025

@kairu-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms kairu-ms merged commit ae1b9d8 into Azure:main Jun 26, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ qumulo-2.0.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=128485141&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants