-
Notifications
You must be signed in to change notification settings - Fork 1.5k
CLI Description Update for Qumulo #8879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @Avish34, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Qumulo CLI extension by bumping the minimum CLI core version, refining command and group descriptions, and renaming an internal property related to private IPs.
- Bumped
azext.minCliCoreVersionfrom 2.61.0 to 2.70.0 - Refined docstrings for create, show, list, delete commands and command groups
- Renamed the
private_ipsproperty toprivate_i_psin several AAZ schema builders
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/qumulo/azext_qumulo/azext_metadata.json | Updated minimum CLI core version |
| src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_wait.py | Renamed private_ips to private_i_ps in schema |
| src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_show.py | Renamed private_ips to private_i_ps and updated docstring |
| src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_list.py | Renamed private_ips to private_i_ps and updated docstring |
| src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_delete.py | Updated delete command docstring |
| src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_create.py | Renamed private_ips to private_i_ps and updated docstring |
| src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/__cmd_group.py | Updated command group docstring |
| src/qumulo/azext_qumulo/aaz/latest/qumulo/__cmd_group.py | Updated top-level command group docstring |
Comments suppressed due to low confidence (4)
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_wait.py:225
- It looks like
private_i_psis a typo ofprivate_ips. Renaming back toprivate_ipswill keep the property consistent with the serialized name and other references.
properties.private_i_ps = AAZListType(
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_show.py:226
- The property name
private_i_psappears to be a typo. It should beprivate_ipsto match the serialized field and other implementations.
properties.private_i_ps = AAZListType(
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_list.py:229
- Renaming this back to
private_ipswill maintain consistency with the schema and avoid breaking references elsewhere.
properties.private_i_ps = AAZListType(
src/qumulo/azext_qumulo/aaz/latest/qumulo/storage/file_system/_create.py:416
- This appears to be an unintended rename. Please revert to
private_ipsso it aligns with the serialized JSON field and existing code references.
properties.private_i_ps = AAZListType(
|
15ea4dc to
08982be
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ qumulo-2.0.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=128485141&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.