-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[AMG]: Deprecate api-key command group #8881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| grafana api-key | sub group grafana api-key added property deprecate_info_target |
|
Hi @ABZhang0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR deprecates the "grafana api-key" command group and updates related documentation to inform users of the change.
- Modified the command group in commands.py to include deprecation information.
- Updated help text in _help.py to emphasize the deprecation and provide guidance towards using service accounts.
- Revised HISTORY.rst to document the deprecation.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/amg/azext_amg/commands.py | Added deprecation info to the "grafana api-key" command group. |
| src/amg/azext_amg/_help.py | Updated help messages with new short and long summaries regarding API keys. |
| src/amg/HISTORY.rst | Updated release notes to include the deprecation of API keys. |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
|
[Release] Update index.json for extension [ amg-2.7.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=129202636&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az grafana api-keyGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)