Skip to content

Conversation

@FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

{AKS} Fix several test cases

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 20, 2025 04:25
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 20, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @FumingZhang,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 20, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes several test cases for the AKS extension by updating test command parameters, adjusting dependency versions in the test environment setup, and refining test group labels in configuration files.

  • Updated AKS test cases to include a new custom headers parameter.
  • Upgraded the vcrpy dependency in the virtual environment setup script.
  • Refined test group labels in JSON configuration files to improve clarity and organization.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Added custom headers parameter for ingress app gateway tests
src/aks-preview/azcli_aks_live_test/scripts/setup_venv.sh Upgraded vcrpy version and updated comment for python3.12 HTTPSHandler fix
src/aks-preview/azcli_aks_live_test/configs/ext_matrix_default.json Adjusted test group labels for deprecation and clarity
src/aks-preview/azcli_aks_live_test/configs/cli_matrix_default.json Updated test groups under the GPU category by adding a new test case
Comments suppressed due to low confidence (6)

src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py:850

  • Consider updating the test case documentation or comments to reference the new '--aks-custom-headers' parameter, ensuring that its purpose and usage are clear.
            "--aks-custom-headers AKSHTTPCustomFeatures=Microsoft.ContainerService/AppGatewayWithOverlayPreview "

src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py:971

  • Consider updating the test case documentation or comments to reference the new '--aks-custom-headers' parameter, ensuring that its purpose and usage are clear.
            "--aks-custom-headers AKSHTTPCustomFeatures=Microsoft.ContainerService/AppGatewayWithOverlayPreview "

src/aks-preview/azcli_aks_live_test/configs/ext_matrix_default.json:30

  • [nitpick] The addition of '[deprecated]' clarifies test group status; consider adding a comment explaining the deprecation rationale to aid future maintainability.
        "[deprecated] workload runtime, missing feature registration": [

src/aks-preview/azcli_aks_live_test/configs/ext_matrix_default.json:33

  • Renaming to 'automatic, no quota' improves clarity; ensure that any related documentation or test filtering logic is updated accordingly.
        "automatic, no quota": [

src/aks-preview/azcli_aks_live_test/configs/cli_matrix_default.json:16

  • Ensure that the newly added test 'test_aks_create_gpu_driver_flow' has adequate test coverage to validate the GPU driver flow scenarios.
            "test_aks_create_gpu_driver_flow"

src/aks-preview/azcli_aks_live_test/scripts/setup_venv.sh:51

  • Verify that upgrading to vcrpy 6.0.2 is compatible across all supported Python versions and consider adding a direct link or reference to commit #69621c6 for additional context.
    pip install vcrpy==6.0.2

@github-actions
Copy link

Hi @FumingZhang

Release Suggestions

Module: aks-preview

  • Please log updates into to src/aks-preview/HISTORY.rst
  • Update VERSION to 18.0.0b16 in src/aks-preview/setup.py

Notes

@zhoxing-ms zhoxing-ms merged commit 055522a into Azure:main Jun 20, 2025
38 checks passed
@FumingZhang FumingZhang deleted the fuming/aks-test-0619 branch September 10, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants