Skip to content

Conversation

@evelyn-ys
Copy link
Member

@evelyn-ys evelyn-ys commented Jun 20, 2025

The secrets in purview test recording file should already be invalid. This PR is just to make repo clean


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 20, 2025 05:51
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 20, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @evelyn-ys,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 20, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Purview account test recording to mask secret keys, preventing sensitive data from appearing in playback.

  • Replaced raw SharedAccessKey values with masked placeholders in the test YAML.
Comments suppressed due to low confidence (1)

src/purview/azext_purview/tests/latest/recordings/test_purview_account.yaml:625

  • [nitpick] Consider using the Azure CLI test framework’s recording processors (e.g., RecordingProcessor or mask_secret) to automatically mask sensitive values instead of manually editing recordings—this ensures consistency and reduces maintenance overhead.
      string: '{"atlasKafkaPrimaryEndpoint":"Endpoint=sb://atlas-f553921a-9b69-4405-b43f-2e6879ce750d.servicebus.windows.net/;SharedAccessKeyName=AlternateSharedAccessKey;SharedAccessKey=********************************************","atlasKafkaSecondaryEndpoint":"Endpoint=sb://atlas-f553921a-9b69-4405-b43f-2e6879ce750d.servicebus.windows.net/;SharedAccessKeyName=AlternateSharedAccessKey;SharedAccessKey=********************************************"}'

@github-actions
Copy link

@evelyn-ys evelyn-ys merged commit 9870d7d into Azure:main Jun 20, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants