-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Create Az CloudHsm Extension for 2025-03-31 #8885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @jkapil, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces a new Azure CLI extension for CloudHSM management and adds support for CloudHSM create, list, show, update, backup, restore, delete, and wait operations using the new 2025-03-31 API version.
- New service entry added in src/service_name.json for CloudHSM
- Complete implementation of the CloudHSM extension including setup, commands (via AAZ), tests and recordings
- Auto-generated command modules and helper utilities for backup/restore and other operations
Reviewed Changes
Copilot reviewed 31 out of 34 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/service_name.json | Added CloudHSM entry with updated CLI command mapping |
| src/cloudhsm/setup.py and related files | New extension setup scripts and package metadata |
| src/cloudhsm/azext_cloudhsm/tests/latest/test_cloudhsm.py | New test suite for CloudHSM commands including backup and restore |
| src/cloudhsm/azext_cloudhsm/aaz/… | Auto-generated AAZ command files for CloudHSM operations |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…tainerUri and not blobContainerUri
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ cloudhsm-1.0.0b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=128194228&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.