Skip to content

Conversation

@cxznmhdcxz
Copy link
Member

@cxznmhdcxz cxznmhdcxz commented Jun 23, 2025

aaz Azure/aaz#789
resolve Azure/azure-cli#31476


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az network firewall create/delete/list/show/update

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 23, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️azure-firewall
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd network firewall create cmd network firewall create added parameter edge_zone
⚠️ 1006 - ParaAdd network firewall threat-intel-allowlist create cmd network firewall threat-intel-allowlist create added parameter extended_location
⚠️ 1006 - ParaAdd network firewall threat-intel-allowlist delete cmd network firewall threat-intel-allowlist delete added parameter extended_location
⚠️ 1006 - ParaAdd network firewall threat-intel-allowlist update cmd network firewall threat-intel-allowlist update added parameter extended_location

@azure-client-tools-bot-prd
Copy link

Hi @cxznmhdcxz,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 23, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Jun 23, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 24, 2025
@necusjz
Copy link
Member

necusjz commented Jun 24, 2025

Hi @cxznmhdcxz

⚠️ Release Requirements

Module: azure-firewall

  • ⚠️ Please update VERSION to be 1.3.0 in src/azure-firewall/setup.py

Notes

just fyi, if there is no breaking changes, refer to https://semver.org/#summary, we cannot update the MAJOR version.

@cxznmhdcxz cxznmhdcxz force-pushed the firewall-extended-location branch from bb274e2 to b185d65 Compare June 24, 2025 08:09
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 24, 2025
@cxznmhdcxz cxznmhdcxz force-pushed the firewall-extended-location branch from b185d65 to 9ed8316 Compare June 24, 2025 09:19
@cxznmhdcxz cxznmhdcxz marked this pull request as ready for review June 25, 2025 02:21
Copilot AI review requested due to automatic review settings June 25, 2025 02:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the extended location feature by enabling the --edge-zone parameter for Azure Firewall creation. Key changes include:

  • Updating the extension version in setup.py from 1.2.3 to 1.3.0.
  • Adding a new scenario test (test_azure_firewall_extended_location) to validate the extended location functionality.
  • Updating test recordings with new API versions, user-agent strings, and metadata to reflect the latest changes in Azure infrastructure.

Reviewed Changes

Copilot reviewed 26 out of 43 changed files in this pull request and generated no comments.

File Description
src/azure-firewall/setup.py Bumped version to 1.3.0 for the new extended location feature.
src/azure-firewall/azext_firewall/tests/latest/test_azure_firewall_scenario.py Added a new test case for extended location support with consistent parameter usage.
src/azure-firewall/azext_firewall/tests/latest/recordings/test_firewall_with_dns_proxy.yaml Updated API versions, user-agent strings, and response details to align with recent changes.

@cxznmhdcxz cxznmhdcxz force-pushed the firewall-extended-location branch from 9ed8316 to c9cac5a Compare June 25, 2025 06:31
@necusjz necusjz merged commit 15743ff into Azure:main Jun 30, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ azure-firewall-1.3.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=128810251&view=results

@cxznmhdcxz cxznmhdcxz deleted the firewall-extended-location branch August 13, 2025 02:54
@bewatersmsft
Copy link
Member

This PR appears to have introduced outdated/ no new recordings to the azext_firewall extension

@bewatersmsft
Copy link
Member

The api-version recorded for public ip addresses was 2022-11-01, but is picking up 2024-07-01

Vnet is was recorded as 2024-07-01, but is picked up as 2024-05-01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Network

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request to add a new optional parameter

5 participants