-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[azure-firewall] az network firewall create: Support --edge-zone parameter for extended location feature
#8892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| network firewall create | cmd network firewall create added parameter edge_zone |
||
| network firewall threat-intel-allowlist create | cmd network firewall threat-intel-allowlist create added parameter extended_location |
||
| network firewall threat-intel-allowlist delete | cmd network firewall threat-intel-allowlist delete added parameter extended_location |
||
| network firewall threat-intel-allowlist update | cmd network firewall threat-intel-allowlist update added parameter extended_location |
|
Hi @cxznmhdcxz, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
just fyi, if there is no breaking changes, refer to https://semver.org/#summary, we cannot update the MAJOR version. |
bb274e2 to
b185d65
Compare
b185d65 to
9ed8316
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the extended location feature by enabling the --edge-zone parameter for Azure Firewall creation. Key changes include:
- Updating the extension version in setup.py from 1.2.3 to 1.3.0.
- Adding a new scenario test (test_azure_firewall_extended_location) to validate the extended location functionality.
- Updating test recordings with new API versions, user-agent strings, and metadata to reflect the latest changes in Azure infrastructure.
Reviewed Changes
Copilot reviewed 26 out of 43 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-firewall/setup.py | Bumped version to 1.3.0 for the new extended location feature. |
| src/azure-firewall/azext_firewall/tests/latest/test_azure_firewall_scenario.py | Added a new test case for extended location support with consistent parameter usage. |
| src/azure-firewall/azext_firewall/tests/latest/recordings/test_firewall_with_dns_proxy.yaml | Updated API versions, user-agent strings, and response details to align with recent changes. |
9ed8316 to
c9cac5a
Compare
|
[Release] Update index.json for extension [ azure-firewall-1.3.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=128810251&view=results |
|
This PR appears to have introduced outdated/ no new recordings to the azext_firewall extension |
|
The api-version recorded for public ip addresses was 2022-11-01, but is picking up 2024-07-01 Vnet is was recorded as 2024-07-01, but is picked up as 2024-05-01 |
aaz Azure/aaz#789
resolve Azure/azure-cli#31476
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az network firewall create/delete/list/show/update
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.