[Storage-Actions] GA 2023-01-01 #8893
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| storage-actions task list-assignment | cmd storage-actions task list-assignment update parameter maxpagesize: updated property aaz_type from string to int |
||
| storage-actions task list-assignment | cmd storage-actions task list-assignment update parameter maxpagesize: updated property type from string to int |
||
| storage-actions task list-report | cmd storage-actions task list-report update parameter maxpagesize: updated property aaz_type from string to int |
||
| storage-actions task list-report | cmd storage-actions task list-report update parameter maxpagesize: updated property type from string to int |
|
Hi @calvinhzy, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @calvinhzy
|
github-actions
bot
added
the
release-version-block
calvinhzy
removed
the
release-version-block
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR promotes the Storage-Actions extension from preview to GA for API version 2023-01-01 by removing preview flags, bumping version metadata, and updating test recordings and code schemas. Key changes include:
- Version bump to 1.0.0 and removal of
is_previewflags across commands - Test updates for new default region (
eastus2) and adjustments to recordings - Schema/type updates: switching identity types to
AAZIdentityObjectType, changing LRO options, and convertingmaxpagesizeargs to integers
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/storage-actions/setup.py | Bumped extension version from 1.0.0b1 to 1.0.0 |
| src/storage-actions/azext_storage_actions/tests/latest/test_storage_actions.py | Updated test region to eastus2; commented out tag checks |
| src/storage-actions/azext_storage_actions/tests/latest/recordings/test_storage_actions_task_preview_action_scenarios.yaml | Updated region, user agent, and timestamps in recordings |
| src/storage-actions/azext_storage_actions/azext_metadata.json | Removed azext.isPreview, bumped minCliCoreVersion |
| src/storage-actions/azext_storage_actions/aaz/latest/storage_actions/task/_wait.py | Changed identity type from AAZObjectType to AAZIdentityObjectType |
| src/storage-actions/azext_storage_actions/aaz/latest/storage_actions/task/_update.py | Removed preview flag; updated LRO via "azure-async-operation" and identity type |
| src/storage-actions/azext_storage_actions/aaz/latest/storage_actions/task/_show.py | Removed preview flag; updated identity type |
| src/storage-actions/azext_storage_actions/aaz/latest/storage_actions/task/_preview_action.py | Removed preview flag |
| src/storage-actions/azext_storage_actions/aaz/latest/storage_actions/task/_list_report.py | Converted --maxpagesize arg from string to integer |
| src/storage-actions/azext_storage_actions/aaz/latest/storage_actions/task/_list_assignment.py | Converted --maxpagesize arg from string to integer |
| src/storage-actions/azext_storage_actions/aaz/latest/storage_actions/task/_list.py | Swapped and simplified resource vs subscription listing logic |
| src/storage-actions/azext_storage_actions/aaz/latest/storage_actions/task/_delete.py | Updated LRO via "azure-async-operation" |
| src/storage-actions/azext_storage_actions/aaz/latest/storage_actions/task/_create.py | Removed preview flag; added mi_system_assigned and mi_user_assigned args; updated LRO and identity type |
| src/storage-actions/azext_storage_actions/aaz/latest/storage_actions/task/__cmd_group.py | Removed preview flag from command group |
| src/storage-actions/azext_storage_actions/aaz/latest/storage_actions/__cmd_group.py | Removed preview flag from command group |
| src/storage-actions/HISTORY.rst | Added GA 1.0.0 release notes |
Comments suppressed due to low confidence (2)
src/storage-actions/azext_storage_actions/tests/latest/test_storage_actions.py:27
- Commenting out the tag assertions removes coverage for tag functionality; consider adding a dedicated test or a conditional check to validate tags once the service regression is resolved.
# JMESPathCheck('tags', {"key1": "value1"}),
src/storage-actions/azext_storage_actions/tests/latest/recordings/test_storage_actions_task_preview_action_scenarios.yaml:69
- The
x-ms-operation-identifierheader still referenceseastus2euap, which is inconsistent with the updated request URI usingeastus2. Update this to avoid playback mismatches.
x-ms-operation-identifier:
| self.pre_operations() | ||
| condition_0 = has_value(self.ctx.args.resource_group) and has_value(self.ctx.subscription_id) | ||
| condition_1 = has_value(self.ctx.subscription_id) and has_value(self.ctx.args.resource_group) is not True | ||
| condition_0 = has_value(self.ctx.subscription_id) and has_value(self.ctx.args.resource_group) is not True |
There was a problem hiding this comment.
[nitpick] Using has_value(...) is not True for boolean negation can be confusing; consider rewriting as not has_value(self.ctx.args.resource_group) for clarity.
| condition_0 = has_value(self.ctx.subscription_id) and has_value(self.ctx.args.resource_group) is not True | |
| condition_0 = has_value(self.ctx.subscription_id) and not has_value(self.ctx.args.resource_group) |
| identity.mi_system_assigned = AAZStrArg( | ||
| options=["system-assigned", "mi-system-assigned"], | ||
| help="Set the system managed identity.", | ||
| blank="True", |
There was a problem hiding this comment.
The blank parameter is set to the string "True"; to correctly indicate a blank default, consider using the boolean True rather than a string.
| blank="True", | |
| blank=True, |
|
[Release] Update index.json for extension [ storage-actions-1.0.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=128805162&view=results |
4 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Azure/aaz#796
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.