-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{spring-cloud} remove spring-cloud extension as it has been deprecated for years #8897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @evelyn-ys, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the entire spring-cloud extension since it has been deprecated for years.
- All source files, test files, configuration files, and metadata related to the spring-cloud extension have been deleted.
- The removal ensures that customers are directed to use the spring extension instead.
Reviewed Changes
Copilot reviewed 65 out of 422 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/spring-cloud/azext_spring_cloud/tests/... | Removed multiple test files and certificate files |
| src/spring-cloud/azext_spring_cloud/*.py | Removed core implementation files including spring_cloud_instance.py, gateway.py, service_registry.py, buildpack_binding.py, application_configuration_service.py, and more |
| src/spring-cloud/azext_spring_cloud/azext_metadata.json | Removed metadata configuration file |
| src/spring-cloud/azext_spring_cloud/aaz/... | Removed AAZ command group files and related modules |
| ... | Other supporting files have been removed to complete deprecation of the extension |
|
customers should use spring extension instead
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.