Skip to content

Conversation

@FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented Jun 24, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

  • Fix test pipeline
  • remove case test_aks_nodepool_abort as it would always fail in live test mode

    At nodepool level the stop is just an update operation of the power state, no separate operation for stop agentpool. So there's no way for us to reset the power code back to running since we lose track of whatever updates have been made already.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 24, 2025 06:41
@azure-client-tools-bot-prd
Copy link

Hi @FumingZhang,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 24, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 24, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request aims to fix the test pipeline issues in the AKS extension by updating the vcrpy dependency and addressing known compatibility issues.

  • Update vcrpy from version 6.0.2 to 7.0.0 to resolve issues with urllib3.
  • Update the corresponding comment to reference the new issue fix.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

Hi @FumingZhang

Release Suggestions

Module: aks-preview

  • Please log updates into to src/aks-preview/HISTORY.rst
  • Update VERSION to 18.0.0b16 in src/aks-preview/setup.py

Notes

@zhoxing-ms zhoxing-ms merged commit 31e0eb9 into Azure:main Jun 25, 2025
24 checks passed
@FumingZhang FumingZhang deleted the fuming/aks-test-0624 branch September 10, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants