Skip to content

Conversation

@caoyihua
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 25, 2025 07:51
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 25, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️vme
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd vme uninstall cmd vme uninstall added parameter force

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 25, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new --force option to the az vme uninstall command, updates tests to cover the new flag, bumps the extension version, and records the change in the history.

  • Bumped extension version to 1.0.0b4
  • Added force parameter in command implementation and CLI parameters
  • Updated a live scenario test to include the new flag

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/vme/setup.py Updated version from 1.0.0b3 to 1.0.0b4
src/vme/azext_vme/tests/latest/test_vme_scenario.py Updated live test to use --force
src/vme/azext_vme/custom.py Extended uninstall_vme signature to accept force and conditionally append it
src/vme/azext_vme/_params.py Added CLI force argument
src/vme/HISTORY.rst Added entry for --force option under version 1.0.0b4
Comments suppressed due to low confidence (3)

src/vme/azext_vme/_params.py:96

  • The 'force' CLI argument is missing an action or arg_type for boolean parsing. Consider using action='store_true' or arg_type=get_three_state_flag to ensure it's treated correctly as a flag.
            'force',

src/vme/azext_vme/tests/latest/test_vme_scenario.py:75

  • The new '--force' behavior is only covered when the flag is provided. Add a test without '--force' to validate the default (non-forced) path.
            self.cmd("vme uninstall -g {rg} -c {cluster_name} --include all --force")

src/vme/HISTORY.rst:20

  • [nitpick] The underline for the '1.0.0b4' heading uses 7 '+' characters but should match the length of the version string for consistency.
++++++

cluster_name: str,
include_extension_types: list[str]):
include_extension_types: list[str],
force=False):
Copy link

Copilot AI Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parameter 'force' lacks a type annotation. Annotate it as 'force: bool = False' for clarity and consistency with other parameters.

Suggested change
force=False):
force: bool = False):

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

@yonzhan yonzhan requested a review from kairu-ms June 25, 2025 08:11
@yonzhan yonzhan requested a review from jsntcy June 25, 2025 08:11
@kairu-ms kairu-ms merged commit e1741a2 into Azure:main Jun 26, 2025
26 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ vme-1.0.0b4 ] : https://dev.azure.com/msazure/One/_build/results?buildId=128477964&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants