Skip to content

Conversation

@robogatikov
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

When Ingress Appgateway Addon is enabled in Azure CNI Overlay cluster and --uppgw-subnet-cidr is specified on cluster create, the cidr should be shorter than /24.

Related command

az aks create

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 25, 2025 15:03
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 25, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @robogatikov,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates an existing test to align with the requirement that the App Gateway subnet CIDR must be shorter than /24 when AGIC is enabled in an Azure CNI Overlay cluster.

  • Changed the --appgw-subnet-cidr value from /16 to /26 in the test command.
  • Updated the expected assertion for the subnetCIDR check to /26.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 25, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

@robogatikov robogatikov force-pushed the robogatikov/fix-test-agic-with-overlay branch from 89a21a9 to 8606c0d Compare June 25, 2025 18:23
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change, test passed!

  • test_aks_create_with_ingress_appgw_addon

@yanzhudd yanzhudd merged commit 4479fb5 into Azure:main Jun 26, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants