Skip to content

Conversation

@makotrik
Copy link
Contributor

Removing Sap-hana cli extension as there are no more customers on this RP . We did not run any tests as there are no resources available and this is complete removal of extension.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 26, 2025 03:01
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 26, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @makotrik,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 26, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes the now-unsupported SAP HANA CLI extension from the Azure CLI index.

  • Deletes the entire sap-hana extension entry from src/index.json
  • No other extensions or dependencies are affected

@github-actions
Copy link

@evelyn-ys
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@makotrik
Copy link
Contributor Author

@microsoft-github-policy agree company="Microsoft"

@wangzelin007
Copy link
Member

@microsoft-github-policy-service agree company="Microsoft"

@wangzelin007 wangzelin007 changed the title Remove hana on azure extension as we no longer support customers on t… Remove hana on azure extension as we no longer support customers on Azure CLI Jun 26, 2025
@wangzelin007 wangzelin007 merged commit 7b7a7c4 into Azure:main Jun 26, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants