-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{Elastic-SAN} az elastic-san volume-group create/update: Add warning for CRC data integration check
#8910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds user warnings related to the new CRC data integrity check flag for Elastic SAN volume groups and prepares the extension for release.
- Introduces warnings in
createandupdateflows when--enforce-data-integrity-check-for-iscsiis set or unset - Bumps extension version to
1.3.1b1 - Updates
HISTORY.rstwith the new release entry
Reviewed Changes
Copilot reviewed 3 out of 8 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/elastic-san/setup.py | Bumped extension version to 1.3.1b1 |
| src/elastic-san/azext_elastic_san/custom.py | Added logger.warning messages for the CRC data integration flag |
| src/elastic-san/HISTORY.rst | Added release history entry for version 1.3.1b1 |
Comments suppressed due to low confidence (1)
src/elastic-san/azext_elastic_san/custom.py:45
- There are no tests verifying that the new warning messages are emitted when the CRC flag is toggled; consider adding unit tests to assert the correct warnings for both enabled and disabled scenarios.
if has_value(args.EnforceDataIntegrityCheckForIscsi) and args.EnforceDataIntegrityCheckForIscsi:
| args.identity["user_assigned_identities"] = { | ||
| uai_id: {}} | ||
| del args.identity.user_assigned_identity_id | ||
| if has_value(args.EnforceDataIntegrityCheckForIscsi) and args.EnforceDataIntegrityCheckForIscsi: |
Copilot
AI
Jun 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning logic for CRC protection is duplicated in both create and update handlers; consider extracting it into a shared helper function to reduce code duplication and simplify future updates.
| args.identity["user_assigned_identities"] = { | ||
| uai_id: {}} | ||
| del args.identity.user_assigned_identity_id | ||
| if has_value(args.EnforceDataIntegrityCheckForIscsi) and args.EnforceDataIntegrityCheckForIscsi: |
Copilot
AI
Jun 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per Azure best practices, consider invoking the azure_development-get_best_practices tool to ensure this CRC warning integration aligns with recommended Azure CLI extension guidelines.
|
[Release] Update index.json for extension [ elastic-san-1.3.1b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=128805219&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.