Skip to content

Conversation

@calvinhzy
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@calvinhzy calvinhzy self-assigned this Jun 28, 2025
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 28, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 28, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Jun 28, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 28, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 28, 2025
@calvinhzy calvinhzy marked this pull request as ready for review June 28, 2025 12:17
Copilot AI review requested due to automatic review settings June 28, 2025 12:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds user warnings related to the new CRC data integrity check flag for Elastic SAN volume groups and prepares the extension for release.

  • Introduces warnings in create and update flows when --enforce-data-integrity-check-for-iscsi is set or unset
  • Bumps extension version to 1.3.1b1
  • Updates HISTORY.rst with the new release entry

Reviewed Changes

Copilot reviewed 3 out of 8 changed files in this pull request and generated 2 comments.

File Description
src/elastic-san/setup.py Bumped extension version to 1.3.1b1
src/elastic-san/azext_elastic_san/custom.py Added logger.warning messages for the CRC data integration flag
src/elastic-san/HISTORY.rst Added release history entry for version 1.3.1b1
Comments suppressed due to low confidence (1)

src/elastic-san/azext_elastic_san/custom.py:45

  • There are no tests verifying that the new warning messages are emitted when the CRC flag is toggled; consider adding unit tests to assert the correct warnings for both enabled and disabled scenarios.
        if has_value(args.EnforceDataIntegrityCheckForIscsi) and args.EnforceDataIntegrityCheckForIscsi:

args.identity["user_assigned_identities"] = {
uai_id: {}}
del args.identity.user_assigned_identity_id
if has_value(args.EnforceDataIntegrityCheckForIscsi) and args.EnforceDataIntegrityCheckForIscsi:
Copy link

Copilot AI Jun 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning logic for CRC protection is duplicated in both create and update handlers; consider extracting it into a shared helper function to reduce code duplication and simplify future updates.

Copilot uses AI. Check for mistakes.
args.identity["user_assigned_identities"] = {
uai_id: {}}
del args.identity.user_assigned_identity_id
if has_value(args.EnforceDataIntegrityCheckForIscsi) and args.EnforceDataIntegrityCheckForIscsi:
Copy link

Copilot AI Jun 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per Azure best practices, consider invoking the azure_development-get_best_practices tool to ensure this CRC warning integration aligns with recommended Azure CLI extension guidelines.

Copilot generated this review using guidance from repository custom instructions.
@yonzhan yonzhan requested review from evelyn-ys and kairu-ms June 28, 2025 22:54
@calvinhzy calvinhzy merged commit 11e9425 into Azure:main Jun 30, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ elastic-san-1.3.1b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=128805219&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants