Skip to content

Conversation

@robogatikov
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create
az aks update

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 30, 2025 19:01
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 30, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @robogatikov,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 30, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the help text for the --pod-cidr and --pod-cidrs flags in the AKS preview extension to reference the new Azure CNI Overlay mode and Kubenet’s planned retirement.

  • Updated short and long summaries for --pod-cidr to include Azure CNI Overlay context and Kubenet deprecation date.
  • Mirrored those changes for --pod-cidrs, adding a link to the Azure CNI Overlay docs.
  • Added aka.ms/aks/azure-cni-overlay reference in both long summaries.
Comments suppressed due to low confidence (2)

src/aks-preview/azext_aks_preview/_help.py:243

  • [nitpick] Consider moving the Kubenet retirement note out of the short-summary into the long-summary for clarity, and adjust casing for consistency (e.g., lowercase 'kubenet' to match existing entries and use lowercase 'on' within parentheses).
          short-summary: A CIDR notation IP range from which to assign pod IPs when Azure CNI Overlay or Kubenet is used (On 31 March 2028, Kubenet will be retired).

src/aks-preview/azext_aks_preview/_help.py:255

  • [nitpick] As above, consider relocating the retirement note to the long-summary and normalizing casing (e.g., lowercase 'kubenet' and 'on') to improve readability and consistency across help entries.
          short-summary: A comma-separated list of CIDR notation IP ranges from which to assign pod IPs when Azure CNI Overlay or Kubenet is used (On 31 March 2028, Kubenet will be retired).

@github-actions
Copy link

Hi @robogatikov

Release Suggestions

Module: aks-preview

  • Please log updates into to src/aks-preview/HISTORY.rst
  • Update VERSION to 18.0.0b16 in src/aks-preview/setup.py

Notes

Copy link
Contributor

@tyler-lloyd tyler-lloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoxing-ms zhoxing-ms merged commit 9c15489 into Azure:main Jul 2, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants