-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Azure CLI Extension for PureStorageBlock #8914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @deepakmauryams, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR scaffolds a new Azure CLI extension named PureStorageBlock, including packaging, metadata, and auto-generated AAZ command modules for various storage-pool subresources.
- Adds extension packaging (
setup.py,setup.cfg) and metadata (azext_metadata.json). - Generates AAZ command implementations for identity, AVS VM, AVS VM volume, and AVS storage container volume resources.
- Includes a placeholder test file for future scenario tests.
Reviewed Changes
Copilot reviewed 75 out of 75 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/purestorageblock/setup.py | Defines package metadata, version, and entry points |
| src/purestorageblock/setup.cfg | Placeholder config (currently empty) |
| src/purestorageblock/azext_purestorageblock/tests/latest/test_purestorageblock.py | Scaffolded test class with a TODO |
Comments suppressed due to low confidence (1)
src/purestorageblock/azext_purestorageblock/tests/latest/test_purestorageblock.py:13
- The test class currently has no assertions. Please add at least one scenario test to verify a basic command execution of this extension.
pass
| @@ -0,0 +1 @@ | |||
| #setup.cfg No newline at end of file | |||
Copilot
AI
Jul 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This setup.cfg is empty and provides no configuration. Consider removing it or populating it with standard tool configurations (e.g., pytest, flake8) or project metadata.
| #setup.cfg | |
| [metadata] | |
| name = purestorageblock | |
| version = 0.1.0 | |
| author = Your Name | |
| author_email = [email protected] | |
| description = A project for managing Pure Storage Block configurations | |
| [options] | |
| packages = find: | |
| python_requires = >=3.7 | |
| [tool:pytest] | |
| testpaths = tests | |
| [flake8] | |
| max-line-length = 88 | |
| exclude = .git,__pycache__,docs,build,dist |
| 'License :: OSI Approved :: MIT License', | ||
| ] | ||
|
|
||
| DEPENDENCIES = [] |
Copilot
AI
Jul 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
install_requires is empty but this extension likely depends on azure-cli-core or Azure SDK packages. Declare runtime dependencies to avoid user installation issues.
|
8988bf6 to
e71c584
Compare
e46b2da to
9a4c4c6
Compare
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.