Skip to content

Conversation

@deepakmauryams
Copy link
Member

@deepakmauryams deepakmauryams commented Jul 1, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 1, 2025 04:37
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @deepakmauryams,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 1, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR scaffolds a new Azure CLI extension named PureStorageBlock, including packaging, metadata, and auto-generated AAZ command modules for various storage-pool subresources.

  • Adds extension packaging (setup.py, setup.cfg) and metadata (azext_metadata.json).
  • Generates AAZ command implementations for identity, AVS VM, AVS VM volume, and AVS storage container volume resources.
  • Includes a placeholder test file for future scenario tests.

Reviewed Changes

Copilot reviewed 75 out of 75 changed files in this pull request and generated 2 comments.

File Description
src/purestorageblock/setup.py Defines package metadata, version, and entry points
src/purestorageblock/setup.cfg Placeholder config (currently empty)
src/purestorageblock/azext_purestorageblock/tests/latest/test_purestorageblock.py Scaffolded test class with a TODO
Comments suppressed due to low confidence (1)

src/purestorageblock/azext_purestorageblock/tests/latest/test_purestorageblock.py:13

  • The test class currently has no assertions. Please add at least one scenario test to verify a basic command execution of this extension.
    pass

@@ -0,0 +1 @@
#setup.cfg No newline at end of file
Copy link

Copilot AI Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setup.cfg is empty and provides no configuration. Consider removing it or populating it with standard tool configurations (e.g., pytest, flake8) or project metadata.

Suggested change
#setup.cfg
[metadata]
name = purestorageblock
version = 0.1.0
author = Your Name
author_email = [email protected]
description = A project for managing Pure Storage Block configurations
[options]
packages = find:
python_requires = >=3.7
[tool:pytest]
testpaths = tests
[flake8]
max-line-length = 88
exclude = .git,__pycache__,docs,build,dist

Copilot uses AI. Check for mistakes.
'License :: OSI Approved :: MIT License',
]

DEPENDENCIES = []
Copy link

Copilot AI Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

install_requires is empty but this extension likely depends on azure-cli-core or Azure SDK packages. Declare runtime dependencies to avoid user installation issues.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Jul 1, 2025

@deepakmauryams deepakmauryams force-pushed the pure-azcli-onboarding branch from e46b2da to 9a4c4c6 Compare July 7, 2025 11:23
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jul 7, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jul 9, 2025
@deepakmauryams deepakmauryams deleted the pure-azcli-onboarding branch August 8, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants