Skip to content

Conversation

@FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

{AKS} Vendor new SDK and bump API version to 2025-05-02-preview

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 1, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @FumingZhang,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 1, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@FumingZhang FumingZhang marked this pull request as ready for review July 1, 2025 04:51
Copilot AI review requested due to automatic review settings July 1, 2025 04:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR vendors the new AKS SDK and bumps the API version used in recorded tests from 2025-04-02-preview to 2025-05-02-preview.

  • Updated api-version query parameter across all AKS preview test recordings to the new preview version.
  • Ensured consistency in all HTTP URIs within the YAML test recordings.

Reviewed Changes

Copilot reviewed 157 out of 255 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_nodepool_max_unavailable.yaml Updated api-version to 2025-05-02-preview
src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_nodepool_max_blocked_nodes.yaml Updated api-version to 2025-05-02-preview
src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_nodepool_get_upgrades.yaml Updated api-version to 2025-05-02-preview
src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_nodepool_drain_timeout.yaml Updated api-version to 2025-05-02-preview
src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_nodepool_delete_with_ignore_pod_disruption_budget.yaml Updated api-version to 2025-05-02-preview
src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_nodepool_delete_machines.yaml Updated api-version to 2025-05-02-preview
src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_nodepool_create_with_nsg_control.yaml Updated api-version to 2025-05-02-preview
src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_nodepool_add_with_workload_runtime.yaml Updated api-version to 2025-05-02-preview
src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_nodepool_add_with_ossku_windowsannual.yaml Updated api-version to 2025-05-02-preview
src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_nodepool_add_with_ossku_windows2022.yaml Updated api-version to 2025-05-02-preview
src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_nodepool_add_with_ossku_ubuntu2204.yaml Updated api-version to 2025-05-02-preview
src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_nodepool_add_with_disable_windows_outbound_nat.yaml Updated api-version to 2025-05-02-preview
src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_managed_namespace.yaml Updated api-version to 2025-05-02-preview
src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_maintenancewindow.yaml Updated api-version to 2025-05-02-preview
src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_maintenanceconfiguration.yaml Updated api-version to 2025-05-02-preview
src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_machine_cmds.yaml Updated api-version to 2025-05-02-preview
(All other recording files similarly updated)

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

@FumingZhang FumingZhang marked this pull request as draft July 1, 2025 05:28
@FumingZhang FumingZhang marked this pull request as ready for review July 2, 2025 01:30
@yanzhudd
Copy link
Contributor

yanzhudd commented Jul 2, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd yanzhudd merged commit 8bced3f into Azure:main Jul 3, 2025
24 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Jul 3, 2025

[Release] Update index.json for extension [ aks-preview-18.0.0b16 ] : https://dev.azure.com/msazure/One/_build/results?buildId=129194812&view=results

@FumingZhang FumingZhang deleted the fuming/aks-sdk-0701 branch September 10, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants