Skip to content

Conversation

@ajgupta42
Copy link
Contributor

[ImageCopy] Fix the issue for sasTokenParsing, removing python related warnings from the sasToken(cmd_output is unfiltered)

Error:
sas_token value is unfiltered getting set as:
/opt/az/lib/python3.12/site-packages/azure/multiapi/storagev2/fileshare/init.py:1: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.\n import('pkg_resources').declare_namespace(name)\nse=2025-07-01T08%3A50Z&sp=xxxxx&spr=https&sv=2022-11-02&ss=b&srt=sco&sig=XXXXXXXXXXXXXXXXXX%2BU4Rc%3D


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az image copy --source-resource-group resourcegroup1 --target-location eastus2 --source-type image --source-object-name ubuntu-2004-test-20250630-1827 --target-resource-group resourcegroup1 --target-name ubuntu-2004-test-20250630-1827-eus2

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

…d warnings from the sasToken(cmd_output is unfiltered)
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 1, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 1, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jul 1, 2025
@microsoft-github-policy-service
Copy link
Contributor

Thank you for your contribution @ajgupta42! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

@ajgupta42
Copy link
Contributor Author

ajgupta42 commented Jul 8, 2025

@zhoxing-ms Please help me by reviewing and approve this minor fix

ajgupta42 and others added 2 commits July 9, 2025 10:53
@ajgupta42 ajgupta42 requested a review from zhoxing-ms July 9, 2025 05:34
@ajgupta42
Copy link
Contributor Author

ajgupta42 commented Jul 11, 2025

@zhoxing-ms Can you please merge it as well, as i don't have write access to the repo+branch

@ajgupta42
Copy link
Contributor Author

@zhoxing-ms In case you missed the last comment, can you please merge it as i don't have write access to the repo+branch ?

@yanzhudd yanzhudd merged commit 9d7a177 into Azure:main Jul 14, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ image-copy-1.0.3 ] : https://dev.azure.com/msazure/One/_build/results?buildId=130263320&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Compute customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants