-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[ImageCopy] Fix the issue for sasTokenParsing, removing python related warnings from the sasToken(cmd_output is unfiltered) #8917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ImageCopy] Fix the issue for sasTokenParsing, removing python related warnings from the sasToken(cmd_output is unfiltered) #8917
Conversation
…d warnings from the sasToken(cmd_output is unfiltered)
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution @ajgupta42! We will review the pull request and get back to you soon. |
|
|
@zhoxing-ms Please help me by reviewing and approve this minor fix |
Co-authored-by: Xing Zhou <[email protected]>
…d warnings from the sasToken(cmd_output is unfiltered)
Co-authored-by: Xing Zhou <[email protected]>
|
@zhoxing-ms Can you please merge it as well, as i don't have write access to the repo+branch |
|
@zhoxing-ms In case you missed the last comment, can you please merge it as i don't have write access to the repo+branch ? |
|
[Release] Update index.json for extension [ image-copy-1.0.3 ] : https://dev.azure.com/msazure/One/_build/results?buildId=130263320&view=results |
[ImageCopy] Fix the issue for sasTokenParsing, removing python related warnings from the sasToken(cmd_output is unfiltered)
Error:
sas_token value is unfiltered getting set as:
/opt/az/lib/python3.12/site-packages/azure/multiapi/storagev2/fileshare/init.py:1: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.\n import('pkg_resources').declare_namespace(name)\nse=2025-07-01T08%3A50Z&sp=xxxxx&spr=https&sv=2022-11-02&ss=b&srt=sco&sig=XXXXXXXXXXXXXXXXXX%2BU4Rc%3D
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az image copy --source-resource-group resourcegroup1 --target-location eastus2 --source-type image --source-object-name ubuntu-2004-test-20250630-1827 --target-resource-group resourcegroup1 --target-name ubuntu-2004-test-20250630-1827-eus2
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.