Skip to content

Conversation

@jaiveerk
Copy link
Contributor

@jaiveerk jaiveerk commented Jul 1, 2025

Replacing references to "web application routing" with app routing

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 1, 2025 21:24
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 1, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @jaiveerk,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 1, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the AKS CLI help text to rebrand the “Web Application Routing” addon as “App Routing” and adjusts related short summaries.

  • Replaces “Web Application Routing” with “App Routing” in multiple help entries.
  • Updates --dns-zone-resource-id and --dns-zone-resource-ids descriptions to reference the App Routing addon.
  • Removes the http_application_routing addon entry from the long-summary list.
Comments suppressed due to low confidence (1)

src/aks-preview/azext_aks_preview/_help.py:174

  • The removal of the http_application_routing line seems unintentional since it differs from the PR description about rebranding Web Application Routing. Please confirm whether this addon should still be listed or if the removal is correct.
            These addons are available:

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

Hi @jaiveerk

Release Suggestions

Module: aks-preview

  • Please log updates into to src/aks-preview/HISTORY.rst
  • Update VERSION to 18.0.0b16 in src/aks-preview/setup.py

Notes

@yonzhan yonzhan requested a review from zhoxing-ms July 1, 2025 22:50
@yonzhan yonzhan requested a review from yanzhudd July 1, 2025 22:51
- gitops : enable GitOps (PREVIEW).
- azure-keyvault-secrets-provider : enable Azure Keyvault Secrets Provider addon.
- web_application_routing : enable Web Application Routing addon (PREVIEW). Specify "--dns-zone-resource-id" to configure DNS.
- web_application_routing : enable the App Routing addon (PREVIEW). Specify "--dns-zone-resource-id" to configure DNS.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about adding a new item "app routing, mark this as deprecated and finally remove it later.

@zhoxing-ms zhoxing-ms merged commit b55f88c into Azure:main Jul 2, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants