-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Removing References to "Web Application Routing" on az aks CLI Help #8920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @jaiveerk, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the AKS CLI help text to rebrand the “Web Application Routing” addon as “App Routing” and adjusts related short summaries.
- Replaces “Web Application Routing” with “App Routing” in multiple help entries.
- Updates
--dns-zone-resource-idand--dns-zone-resource-idsdescriptions to reference the App Routing addon. - Removes the
http_application_routingaddon entry from the long-summary list.
Comments suppressed due to low confidence (1)
src/aks-preview/azext_aks_preview/_help.py:174
- The removal of the
http_application_routingline seems unintentional since it differs from the PR description about rebranding Web Application Routing. Please confirm whether this addon should still be listed or if the removal is correct.
These addons are available:
|
Hi @jaiveerk Release SuggestionsModule: aks-preview
Notes
|
| - gitops : enable GitOps (PREVIEW). | ||
| - azure-keyvault-secrets-provider : enable Azure Keyvault Secrets Provider addon. | ||
| - web_application_routing : enable Web Application Routing addon (PREVIEW). Specify "--dns-zone-resource-id" to configure DNS. | ||
| - web_application_routing : enable the App Routing addon (PREVIEW). Specify "--dns-zone-resource-id" to configure DNS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about adding a new item "app routing, mark this as deprecated and finally remove it later.
Replacing references to "web application routing" with app routing
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aksGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.