Skip to content

Conversation

@FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented Jul 2, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

{AKS} Fix #8907: Remove deprecated pkg_resources declare namespace

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 2, 2025 07:48
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 2, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 2, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes a deprecated namespace declaration from the vendored SDK, bumps the extension version, and adds a history entry to reflect the change.

  • Bump version to 18.0.0b16 in setup.py
  • Remove pkg_resources.declare_namespace call from vendored_sdks/__init__.py
  • Update HISTORY.rst with a new 18.0.0b16 entry

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/aks-preview/setup.py Version updated from 18.0.0b15 to 18.0.0b16
src/aks-preview/azext_aks_preview/vendored_sdks/init.py Removed deprecated namespace declaration
src/aks-preview/HISTORY.rst Added new version header and change note
Comments suppressed due to low confidence (1)

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

@FumingZhang FumingZhang force-pushed the fuming/fix-namespace-pkg-0702 branch from d0b5b75 to c0ea336 Compare July 3, 2025 04:23
@yanzhudd yanzhudd merged commit 9a00713 into Azure:main Jul 3, 2025
24 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Jul 3, 2025

[Release] Update index.json for extension [ aks-preview-18.0.0b17 ] : https://dev.azure.com/msazure/One/_build/results?buildId=129214573&view=results

@FumingZhang FumingZhang deleted the fuming/fix-namespace-pkg-0702 branch September 10, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aks-preview] UserWarning: pkg_resources is deprecated as an API

5 participants