-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Updating Elastic API descriptions #8923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @jkore1911, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Elastic extension version and refreshes Elastic monitor tests and recordings to align with the new 2024-06-15-preview API, new SKU naming, and added features.
- Bump extension version from 1.0.0b2 to 1.0.0b3
- Update test commands to use SKU "ess-consumption-2024_Monthly", add
--debug, and include new monitor features (OpenAI integration, monitored subscriptions) - Refresh recording YAML for the updated API version and corrected timestamps
Reviewed Changes
Copilot reviewed 70 out of 71 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/elastic/setup.py | Version bumped to 1.0.0b3 |
| src/elastic/azext_elastic/tests/latest/test_elastic_scenario.py | Tests updated for new SKU names, added OpenAI and subscription tests |
| src/elastic/azext_elastic/tests/latest/recordings/test_elastic_monitor_tag_rule.yaml | Recording refreshed for 2024-06-15-preview API and new debug flag |
Comments suppressed due to low confidence (3)
src/elastic/azext_elastic/tests/latest/test_elastic_scenario.py:28
- [nitpick] Including '--debug' in test commands adds noise to recordings and may cause flakiness; consider removing it unless explicitly needed for debugging.
'--sku "{{\\"name\\":\\"ess-consumption-2024_Monthly\\"}}" --debug', checks=[
src/elastic/azext_elastic/tests/latest/recordings/test_elastic_monitor_tag_rule.yaml:498
- The recording entry for 'request:' has lost its leading dash in the sequence, which can break YAML parsing of the interactions list. Ensure each request/response block starts with '-' to maintain a valid sequence.
- request:
src/elastic/azext_elastic/tests/latest/test_elastic_scenario.py:22
- The 'ruleSetId' key is added to self.kwargs but never used in any subsequent command. Consider removing it or using it in a test command to keep the test data relevant.
'ruleSetId': '31d91b5afb6f4c2eaaf104c97b1991dd'
|
Hi @jkore1911
|
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.