Skip to content

Conversation

@jkore1911
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 2, 2025 10:33
@jkore1911 jkore1911 requested review from jsntcy and kairu-ms as code owners July 2, 2025 10:33
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @jkore1911,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 2, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@jkore1911 jkore1911 closed this Jul 2, 2025
@github-actions
Copy link

github-actions bot commented Jul 2, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Elastic extension version and refreshes Elastic monitor tests and recordings to align with the new 2024-06-15-preview API, new SKU naming, and added features.

  • Bump extension version from 1.0.0b2 to 1.0.0b3
  • Update test commands to use SKU "ess-consumption-2024_Monthly", add --debug, and include new monitor features (OpenAI integration, monitored subscriptions)
  • Refresh recording YAML for the updated API version and corrected timestamps

Reviewed Changes

Copilot reviewed 70 out of 71 changed files in this pull request and generated no comments.

File Description
src/elastic/setup.py Version bumped to 1.0.0b3
src/elastic/azext_elastic/tests/latest/test_elastic_scenario.py Tests updated for new SKU names, added OpenAI and subscription tests
src/elastic/azext_elastic/tests/latest/recordings/test_elastic_monitor_tag_rule.yaml Recording refreshed for 2024-06-15-preview API and new debug flag
Comments suppressed due to low confidence (3)

src/elastic/azext_elastic/tests/latest/test_elastic_scenario.py:28

  • [nitpick] Including '--debug' in test commands adds noise to recordings and may cause flakiness; consider removing it unless explicitly needed for debugging.
             '--sku "{{\\"name\\":\\"ess-consumption-2024_Monthly\\"}}" --debug', checks=[

src/elastic/azext_elastic/tests/latest/recordings/test_elastic_monitor_tag_rule.yaml:498

  • The recording entry for 'request:' has lost its leading dash in the sequence, which can break YAML parsing of the interactions list. Ensure each request/response block starts with '-' to maintain a valid sequence.
- request:

src/elastic/azext_elastic/tests/latest/test_elastic_scenario.py:22

  • The 'ruleSetId' key is added to self.kwargs but never used in any subsequent command. Consider removing it or using it in a test command to keep the test data relevant.
        'ruleSetId': '31d91b5afb6f4c2eaaf104c97b1991dd'

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

Hi @jkore1911

⚠️ Release Requirements

Module: elastic

  • ⚠️ Please update VERSION to be 1.0.0b4 in src/elastic/setup.py

Notes

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants