Skip to content

Conversation

@jkore1911
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 2, 2025 11:46
@jkore1911 jkore1911 requested review from jsntcy and kairu-ms as code owners July 2, 2025 11:46
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 2, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @jkore1911,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 2, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enriches API command summaries and updates a test scenario with a new OpenAI resource configuration.

  • Updated test values for openAIResourceId and openAIResourceEndpoint in test_elastic_scenario.py
  • Expanded docstrings across multiple Elastic monitor commands for clarity and consistency

Reviewed Changes

Copilot reviewed 51 out of 55 changed files in this pull request and generated no comments.

File Description
src/elastic/azext_elastic/tests/latest/test_elastic_scenario.py Updated OpenAI resource ID and endpoint in test data
src/elastic/azext_elastic/aaz/latest/elastic/monitor/** Enhanced docstrings for Elastic monitor commands
src/elastic/azext_elastic/aaz/latest/elastic/monitor/open_ai_integration/_get_statu.py Noted inconsistency in command/class naming
Comments suppressed due to low confidence (2)

src/elastic/azext_elastic/aaz/latest/elastic/monitor/open_ai_integration/_get_statu.py:17

  • The class and command name 'GetStatu' appear to have a typo. Rename them to 'GetStatus' and update the command to 'get-status' to match standard naming conventions.
class GetStatu(AAZCommand):

src/elastic/azext_elastic/tests/latest/test_elastic_scenario.py:134

  • [nitpick] Add a space after the colon in the 'key' entry for consistency with surrounding dictionary formatting, e.g., 'key': '9e1bac69b92242129ad1f2373dd06939',.
            'key':'9e1bac69b92242129ad1f2373dd06939',

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

Hi @jkore1911

Release Suggestions

Module: elastic

  • Please log updates into to src/elastic/HISTORY.rst
  • Update VERSION to 1.0.0b4 in src/elastic/setup.py

Notes

@necusjz necusjz merged commit fdb6a2e into Azure:main Jul 3, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants