Skip to content

Conversation

@idanielsteven
Copy link
Contributor

@idanielsteven idanielsteven commented Jul 2, 2025

  • Re-enables the networkfabric device refresh-configuration command that was removed for lack of support.
  • Update networkfabric device refresh-configuration and reboot command parameters 'network-device-name' to 'resource-name' for consistency.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

…parameters 'network-device-name' to 'resource-name' for consistency.
Copilot AI review requested due to automatic review settings July 2, 2025 14:30
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 2, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️managednetworkfabric
rule cmd_name rule_message suggest_message
⚠️ 1010 - ParaPropUpdate networkfabric device reboot cmd networkfabric device reboot update parameter network_device_name: updated property options from ['--network-device-name'] to ['--network-device-name', '--resource-name']
⚠️ 1001 - CmdAdd networkfabric device refresh-configuration cmd networkfabric device refresh-configuration added

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 2, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the CLI commands for networkfabric device operations to use a consistent --resource-name parameter instead of --network-device-name, and enables the refresh-configuration command.

  • Bumps extension version to 8.0.0b6.
  • Renames --network-device-name to --resource-name for both device refresh-configuration and device reboot commands.
  • Adds tests and recording file updates for the renamed parameters and re-enables the refresh-configuration command.

Reviewed Changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/managednetworkfabric/setup.py Bumped version to 8.0.0b6
tests/latest/test_device_refresh_configuration.py Added scenario test using --resource-name
tests/latest/test_device_reboot_*.py (all reboot tests) Updated CLI invocation to use --resource-name
tests/latest/recordings/*.yaml (all reboot recordings) Updated ParameterSetName entries to use --resource-name
aaz/latest/networkfabric/device/_refresh_configuration.py Implemented new RefreshConfiguration command with --resource-name
aaz/latest/networkfabric/device/_reboot.py Replaced network_device_name arg with resource_name
aaz/latest/networkfabric/device/init.py Imported the new refresh-configuration command
src/managednetworkfabric/HISTORY.rst Added 8.0.0b6 release notes
Comments suppressed due to low confidence (1)

src/managednetworkfabric/azext_managednetworkfabric/tests/latest/test_device_refresh_configuration.py:40

  • Consider adding a scenario to test the --no-wait flag for the refresh-configuration command to ensure LRO no-wait support is covered.
    test.cmd(

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

@necusjz necusjz merged commit e22162f into Azure:main Jul 4, 2025
24 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Jul 4, 2025

[Release] Update index.json for extension [ managednetworkfabric-8.0.0b6 ] : https://dev.azure.com/msazure/One/_build/results?buildId=129316693&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants