-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update networkfabric device refresh-configuration and reboot command parameters #8926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…parameters 'network-device-name' to 'resource-name' for consistency.
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| networkfabric device reboot | cmd networkfabric device reboot update parameter network_device_name: updated property options from ['--network-device-name'] to ['--network-device-name', '--resource-name'] |
||
| networkfabric device refresh-configuration | cmd networkfabric device refresh-configuration added |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the CLI commands for networkfabric device operations to use a consistent --resource-name parameter instead of --network-device-name, and enables the refresh-configuration command.
- Bumps extension version to 8.0.0b6.
- Renames
--network-device-nameto--resource-namefor bothdevice refresh-configurationanddevice rebootcommands. - Adds tests and recording file updates for the renamed parameters and re-enables the
refresh-configurationcommand.
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/managednetworkfabric/setup.py | Bumped version to 8.0.0b6 |
| tests/latest/test_device_refresh_configuration.py | Added scenario test using --resource-name |
| tests/latest/test_device_reboot_*.py (all reboot tests) | Updated CLI invocation to use --resource-name |
| tests/latest/recordings/*.yaml (all reboot recordings) | Updated ParameterSetName entries to use --resource-name |
| aaz/latest/networkfabric/device/_refresh_configuration.py | Implemented new RefreshConfiguration command with --resource-name |
| aaz/latest/networkfabric/device/_reboot.py | Replaced network_device_name arg with resource_name |
| aaz/latest/networkfabric/device/init.py | Imported the new refresh-configuration command |
| src/managednetworkfabric/HISTORY.rst | Added 8.0.0b6 release notes |
Comments suppressed due to low confidence (1)
src/managednetworkfabric/azext_managednetworkfabric/tests/latest/test_device_refresh_configuration.py:40
- Consider adding a scenario to test the
--no-waitflag for therefresh-configurationcommand to ensure LRO no-wait support is covered.
test.cmd(
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
|
[Release] Update index.json for extension [ managednetworkfabric-8.0.0b6 ] : https://dev.azure.com/msazure/One/_build/results?buildId=129316693&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.