-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Remove ingress min-replicas, max-replicas parameters #8928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @Tratcher, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @Tratcher Release SuggestionsModule: containerapp
Notes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the now-obsolete --min-replicas and --max-replicas parameters from the premium ingress commands and underlying logic, relying instead on workload profile–driven scaling. It updates the command implementations, parameter definitions, tests, help examples, and release notes to reflect this design change.
- Drop
min_replicas/max_replicasfromaddandupdatecommand signatures and logic - Remove corresponding CLI arguments and update help text examples
- Adjust tests to no longer assert on removed scale properties and update HISTORY
|
Is this PR ready to merge? |
|
@yanzhudd yes please |
This reverts commit 1dca2de.
Due to a design change these two parameters are no longer needed. Ingress will instead scale to one large instance per workload profile node.
Contributes to https://msazure.visualstudio.com/Antares/_workitems/edit/33117299
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp env premium-ingress add/update
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)