Skip to content

Conversation

@Tratcher
Copy link
Contributor

@Tratcher Tratcher commented Jul 2, 2025

Due to a design change these two parameters are no longer needed. Ingress will instead scale to one large instance per workload profile node.

Contributes to https://msazure.visualstudio.com/Antares/_workitems/edit/33117299


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp env premium-ingress add/update

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 2, 2025

❌Azure CLI Extensions Breaking Change Test
❌containerapp
rule cmd_name rule_message suggest_message
1007 - ParaRemove containerapp env premium-ingress add cmd containerapp env premium-ingress add removed parameter max_replicas please add back parameter max_replicas for cmd containerapp env premium-ingress add
1007 - ParaRemove containerapp env premium-ingress add cmd containerapp env premium-ingress add removed parameter min_replicas please add back parameter min_replicas for cmd containerapp env premium-ingress add
1007 - ParaRemove containerapp env premium-ingress update cmd containerapp env premium-ingress update removed parameter max_replicas please add back parameter max_replicas for cmd containerapp env premium-ingress update
1007 - ParaRemove containerapp env premium-ingress update cmd containerapp env premium-ingress update removed parameter min_replicas please add back parameter min_replicas for cmd containerapp env premium-ingress update

@azure-client-tools-bot-prd
Copy link

Hi @Tratcher,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 2, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

Hi @Tratcher

Release Suggestions

Module: containerapp

  • Update VERSION to 1.2.0b2 in src/containerapp/setup.py

Notes

@Tratcher Tratcher marked this pull request as ready for review July 3, 2025 17:18
Copilot AI review requested due to automatic review settings July 3, 2025 17:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the now-obsolete --min-replicas and --max-replicas parameters from the premium ingress commands and underlying logic, relying instead on workload profile–driven scaling. It updates the command implementations, parameter definitions, tests, help examples, and release notes to reflect this design change.

  • Drop min_replicas/max_replicas from add and update command signatures and logic
  • Remove corresponding CLI arguments and update help text examples
  • Adjust tests to no longer assert on removed scale properties and update HISTORY

@yanzhudd
Copy link
Contributor

yanzhudd commented Jul 9, 2025

Is this PR ready to merge?

@Tratcher
Copy link
Contributor Author

@yanzhudd yes please

@zhoxing-ms zhoxing-ms merged commit 1dca2de into Azure:main Jul 25, 2025
38 checks passed
Juliehzl added a commit to Juliehzl/azure-cli-extensions that referenced this pull request Jul 30, 2025
evelyn-ys pushed a commit that referenced this pull request Jul 30, 2025
* Revert "Remove ingress scale settings (#8928)"

This reverts commit 1dca2de.

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants